Page MenuHomePhabricator
Differential D4242

[gitian-build] Split apart building and signing the build
Needs RevisionPublic
Actions

Authored by jasonbcox on Oct 11 2019, 03:43.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Summary

Depending on user environment and/or automation infrastructure, we may not want to automatically sign the build
in conjunction with said build. This patch splits those two processes apart so they can be run separately.

This gets us a step closer to consolidating our gitian infra and potentially removing /contrib/teamcity/gitian.sh all together.

Depends on D4241

Test Plan
./gitian-build.py -c -n -b -o m v0.20.3  # builds

./gitian-build.py -c -n -i -o m v0.20.3  # errors as expected

./gitian-build.py -c -n -i -o m -s gitianuser v0.20.3  # produces gitian.sigs/*-build.assert and gitian.sigs/*-build.assert.sig

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian-split-sign-build
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7745
Build 13529: Bitcoin ABC Buildbot (legacy)
Build 13528: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 11 2019, 03:43
Herald added a reviewer: deadalnix. · View Herald TranscriptOct 11 2019, 03:43
teamcity added a comment.Oct 11 2019, 03:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 11 2019, 03:53

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7745: Diff 13499.Oct 11 2019, 03:53
jasonbcox mentioned this in D4241: [gitian-build] Rename ambiguous --sign argument.Oct 16 2019, 23:57
Fabien requested changes to this revision.Nov 7 2019, 21:05
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/gitian-build.py
303

Style nit: spaces around the operator

304

Dito

305

sys.exit(1)

This revision now requires changes to proceed.Nov 7 2019, 21:05
teamcity added a comment.Nov 27 2019, 00:09

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Nov 27 2019, 00:09

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing failed.

teamcity added a comment.Nov 27 2019, 00:10

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Nov 27 2019, 00:10

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing failed.

teamcity added a comment.Nov 27 2019, 00:11

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing started.

teamcity added a comment.Nov 27 2019, 00:14

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Nov 27 2019, 00:15

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing failed.

teamcity added a comment.Nov 27 2019, 00:15

Build Bitcoin-ABC / Diffs (Resource Intensive) / Resource Intensive Diff Testing failed.

Revision Contents
Changeset List

PathSize
contrib/
54 lines

Diff 13499

View Options

contrib/gitian-build.py

Loading...