Page MenuHomePhabricator

[gitian-build] Split apart building and signing the build
Needs RevisionPublic

Authored by jasonbcox on Oct 11 2019, 03:43.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Summary

Depending on user environment and/or automation infrastructure, we may not want to automatically sign the build
in conjunction with said build. This patch splits those two processes apart so they can be run separately.

This gets us a step closer to consolidating our gitian infra and potentially removing /contrib/teamcity/gitian.sh all together.

Depends on D4241

Test Plan
./gitian-build.py -c -n -b -o m v0.20.3  # builds

./gitian-build.py -c -n -i -o m v0.20.3  # errors as expected

./gitian-build.py -c -n -i -o m -s gitianuser v0.20.3  # produces gitian.sigs/*-build.assert and gitian.sigs/*-build.assert.sig

Diff Detail

Repository
rABC Bitcoin ABC
Branch
gitian-split-sign-build
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7745
Build 13529: Bitcoin ABC Buildbot (legacy)
Build 13528: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Oct 11 2019, 03:43
Fabien requested changes to this revision.Nov 7 2019, 21:05
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/gitian-build.py
303

Style nit: spaces around the operator

304

Dito

305

sys.exit(1)

This revision now requires changes to proceed.Nov 7 2019, 21:05