Paths

Table of Contentst

Differential D4251

Change CDnsSeedOpts to use std::string instead of c-strings
ClosedPublic
Actions

Authored by nakihito on Oct 14 2019, 22:05.

Tags

None

Subscribers

None

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGbbfb8effa8f8: Change CDnsSeedOpts to use std::string instead of c-strings
rABCbbfb8effa8f8: Change CDnsSeedOpts to use std::string instead of c-strings

Summary

Using std::string is safer, easier to read, and more flexible for future
changes. This additionally paves the way for a smoother integration of
gArgs to replace get_opts().

Depends on D4250

Test Plan

make
./bitcoin-seeder

Kill bitcoin-seeder

./bitcoin-seeder -h seeder.bitframe.org -n dev.bitframe.org -p 5364 -m info@bitframe.org --testnet -w 1,5 -t 95 -d 5 --wipeban --wipeignore

The first bitcoin-seeder call should output something like below:

Supporting whitelisted filters: 0x1,0x5,0x11,0x15
No nameserver set. Not starting DNS server.
Loading dnsseed.dat...done
Starting seeder...done
Starting 96 crawler threads...2019-10-14T22:16:06Z connect() to [2600:8806:8600:1d0:a5f0:9863:3144:6f16]:28333 failed: Cannot assign requested address (99)
...

The second bitcoin-seeder call should output something like below:

Supporting whitelisted filters: 0x1,0x5
Using testnet.
Loading dnsseed.dat...Ban list wiped...Ignore list wiped...done
Starting 5 DNS threads for seeder.bitframe.org on dev.bitframe.org (port 5364)........done
Starting seeder...done
Starting 95 crawler threads...2019-10-14T20:04:11Z connect() to [2600:8806:8600:1d0:a5f0:9863:3144:6f16]:28333 failed: Cannot assign requested address (99)
...

Diff Detail

Repository

rABC Bitcoin ABC

Branch

UpdateSeederHelp-3

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7790
Build 13617: Bitcoin ABC Buildbot (legacy)
Build 13616: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 14 2019, 22:05

Owners added a reviewer: Restricted Owners Package.Oct 14 2019, 22:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 14 2019, 22:05

nakihito planned changes to this revision.Oct 14 2019, 22:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7766: Diff 13543.Oct 14 2019, 22:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito edited the summary of this revision. (Show Details)Oct 14 2019, 22:16

nakihito added a parent revision: D4250: Introduce constant default variables to initialize seeder options.

nakihito edited the test plan for this revision. (Show Details)Oct 14 2019, 22:19

Rebased.

nakihito planned changes to this revision.Oct 14 2019, 22:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Oct 14 2019, 22:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7768: Diff 13545.Oct 14 2019, 22:31

I don't agree that this is easier to read, but I do agree with where this is heading and that it will integrate with ArgsManager better.

This revision is now accepted and ready to land.Oct 15 2019, 00:19

Rebased.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7790: Diff 13581.Oct 16 2019, 18:19

Closed by commit rABCbbfb8effa8f8: Change CDnsSeedOpts to use std::string instead of c-strings (authored by nakihito). · Explain WhyOct 16 2019, 20:38

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCbbfb8effa8f8: Change CDnsSeedOpts to use std::string instead of c-strings.

nakihito added a commit: rSTAGINGbbfb8effa8f8: Change CDnsSeedOpts to use std::string instead of c-strings.Apr 7 2020, 21:26

Revision Contents
Changeset List

Path

Size

src/

seeder/

65 lines

Diff 13581

src/seeder/main.cpp

Loading...