Paths

Table of Contentst

Differential D4266

[mempool] Mark mempool import fails that were found in mempool as 'already there'
ClosedPublic
Actions

Authored by fpelliccioni on Oct 17 2019, 17:38.

Tags

None

Subscribers

None

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already…
rABCd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already…

Summary

I was investigating the reasons for failed imports in mempool and noticed that LoadMempool() and pwallet->postInitProcess() (for all wallets) are executed concurrently. The wallet will end up importing transactions that LoadMempool() later tries to import; the latter will fail due to the tx already being in the mempool.

Backport of Bitcoin Core PR11062
https://github.com/bitcoin/bitcoin/pull/11062

Test Plan

make check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

fpelliccioni created this revision.Oct 17 2019, 17:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 17 2019, 17:38

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni added a child revision: D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.Oct 17 2019, 17:39

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7797: Diff 13590.Oct 17 2019, 17:49

Fabien accepted this revision.Oct 18 2019, 07:12

This revision is now accepted and ready to land.Oct 18 2019, 07:12

Closed by commit rABCd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already… (authored by Karl-Johan Alm <karljohan-alm@garage.co.jp>, committed by fpelliccioni). · Explain WhyOct 18 2019, 14:24

This revision was automatically updated to reflect the committed changes.

fpelliccioni added a commit: rABCd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already….

fpelliccioni mentioned this in D4243: rpc: Expose g_is_mempool_loaded via getmempoolinfo.Oct 24 2019, 18:39

fpelliccioni added a commit: rSTAGINGd2a40c0a60e2: [mempool] Mark mempool import fails that were found in mempool as 'already….Apr 7 2020, 21:27

Revision Contents
Changeset List

Path

Size

src/

21 lines

Diff 13606

src/validation.cpp

Loading...