- Build with Clang in Debug mode:
CXX=clang++ CC=clang cmake .. -D CMAKE_CXX_FLAGS="-Werror=thread-safety-analysis" -GNinja -DCMAKE_BUILD_TYPE=Debug ninja check-all
- Verify that the compiler has not emitted a thread-safety warning.
- Run the node: ./src/bitcoind -regtest
- Verify that text similar to "Assertion failed: lock ... not held ..." is not printed on stderr.
- Run benchmarks:
cmake .. -GNinja ninja bench-bitcoin ./src/bench/bitcoin-bench
It looks like you have dependencies to backport first.
|87 ↗||(On Diff #13508)|
This is not part of the original patch. Is that something we missed somewhere else?
|18 ↗||(On Diff #13508)|
There is something missing here. This API is redundant, the txid is already retrievable from the tx in the CTxMemPoolEntry. This is not required int he original PR, so there is some dependency missing.
|35 ↗||(On Diff #13508)|
This isn't what the original PR is doing.
|37 ↗||(On Diff #13508)|
|240 ↗||(On Diff #13508)|
This is not part of the original PR. Once again, this hints at a missing dependency.
|1490 ↗||(On Diff #13508)|
This is not part of the original PR.
|1515 ↗||(On Diff #13508)|
|14 ↗||(On Diff #13508)|
That ordering choice is puzzling.
I ordered the dependencies based on the date of the log:
12aa2ac98 - Merge #15323: rpc: Expose g_is_mempool_loaded via getmempoolinfo (2019-05-01 ~ 5 months ago) <MarcoFalke> 3515612e0 - Merge #15473: bench: Benchmark MempoolToJSON (2019-03-06 ~ 7 months ago) <MarcoFalke>