mempool: remove unused magic number from consistency check
ClosedPublic
Actions

Authored by fpelliccioni on Oct 22 2019, 13:38.

Details

Reviewers

Fabien
deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGa76b928ad0d6: mempool: remove unused magic number from consistency check
rABCa76b928ad0d6: mempool: remove unused magic number from consistency check

Summary

Unexplained magic numbers are no good. Since the exact number does not matter, opt for a constant that is less peculiar.

Backport of Bitcoin Core PR16056
https://github.com/bitcoin/bitcoin/pull/16056

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

feature-backport-de458da0c

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7832
Build 13686: Bitcoin ABC Buildbot (legacy)
Build 13685: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Oct 22 2019, 13:38

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 22 2019, 13:38

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni edited the test plan for this revision. (Show Details)Oct 22 2019, 13:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7832: Diff 13641.Oct 22 2019, 13:47

deadalnix accepted this revision.Oct 22 2019, 15:22

This revision is now accepted and ready to land.Oct 22 2019, 15:22

Closed by commit rABCa76b928ad0d6: mempool: remove unused magic number from consistency check (authored by Gregory Sanders <gsanders87@gmail.com>, committed by fpelliccioni). · Explain WhyOct 22 2019, 19:43

This revision was automatically updated to reflect the committed changes.

fpelliccioni added a commit: rABCa76b928ad0d6: mempool: remove unused magic number from consistency check.

fpelliccioni added a commit: rSTAGINGa76b928ad0d6: mempool: remove unused magic number from consistency check.Apr 7 2020, 21:28

Revision Contents
Changeset List

Path

Size

src/

txmempool.cpp

2 lines

Diff 13641

View Options

mempool: remove unused magic number from consistency checkClosedPublicActions