Page MenuHomePhabricator

Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax
ClosedPublic

Authored by nakihito on Tue, Oct 29, 21:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC9fdcff469a57: Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax
Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28

Test Plan
make check
./bitcoin-qt
Options -> Encrypt Wallet

Follow instructions and encrypt wallet.

./bitcoin-qt
Options -> Change Password

Follow instructions and change password.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Tue, Oct 29, 21:14
Owners added a reviewer: Restricted Owners Package.Tue, Oct 29, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Oct 29, 21:14
nakihito retitled this revision from Update askpassphrasedialog.cpp to use Qt5 connect syntax to Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax.Tue, Oct 29, 21:17
jasonbcox accepted this revision.Tue, Oct 29, 21:47
This revision is now accepted and ready to land.Tue, Oct 29, 21:47