Page MenuHomePhabricator

Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax
ClosedPublic

Authored by nakihito on Oct 29 2019, 21:14.

Details

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28

Test Plan
make check
./bitcoin-qt
Options -> Encrypt Wallet

Follow instructions and encrypt wallet.

./bitcoin-qt
Options -> Change Password

Follow instructions and change password.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13529-4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7903
Build 13816: Bitcoin ABC Buildbot (legacy)
Build 13815: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Oct 29 2019, 21:14
nakihito retitled this revision from Update askpassphrasedialog.cpp to use Qt5 connect syntax to Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax.Oct 29 2019, 21:17
This revision is now accepted and ready to land.Oct 29 2019, 21:47