Page MenuHomePhabricator
Differential D4309

Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 29 2019, 21:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9fdcff469a57: Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax
rABC9fdcff469a57: Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax
Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28

Test Plan
make check
./bitcoin-qt
Options -> Encrypt Wallet

Follow instructions and encrypt wallet.

./bitcoin-qt
Options -> Change Password

Follow instructions and change password.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13529-4
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7903
Build 13816: Bitcoin ABC Buildbot (legacy)
Build 13815: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 29 2019, 21:14
Owners added a reviewer: Restricted Owners Package.Oct 29 2019, 21:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 29 2019, 21:14
teamcity added a comment.Oct 29 2019, 21:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito retitled this revision from Update askpassphrasedialog.cpp to use Qt5 connect syntax to Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax.Oct 29 2019, 21:17
teamcity added a comment.Oct 29 2019, 21:24

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7903: Diff 13758.Oct 29 2019, 21:24
jasonbcox accepted this revision.Oct 29 2019, 21:47
This revision is now accepted and ready to land.Oct 29 2019, 21:47
Closed by commit rABC9fdcff469a57: Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax (authored by nakihito). · Explain WhyOct 29 2019, 21:58
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC9fdcff469a57: Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax.
nakihito added a commit: rSTAGING9fdcff469a57: Update qt/askpassphrasedialog.cpp to use Qt5 connect syntax.Apr 7 2020, 21:31

Revision Contents
Changeset List

PathSize
src/
qt/
16 lines

Diff 13758

View Options

src/qt/askpassphrasedialog.cpp

Loading...