Update qt/modaloverlay.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 00:15.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING384fb8c0c4f9: Update qt/modaloverlay.cpp with Qt5 connect syntax
rABC384fb8c0c4f9: Update qt/modaloverlay.cpp with Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-7285193040d20d3f795694215e083efc

Test Plan

make check
./bitcoin-qt

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-6

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7909
Build 13828: Bitcoin ABC Buildbot (legacy)
Build 13827: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 30 2019, 00:15

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 00:15

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 00:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7909: Diff 13771.Oct 30 2019, 00:45

deadalnix accepted this revision.Oct 30 2019, 15:28

This revision is now accepted and ready to land.Oct 30 2019, 15:28

Closed by commit rABC384fb8c0c4f9: Update qt/modaloverlay.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 30 2019, 18:00

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC384fb8c0c4f9: Update qt/modaloverlay.cpp with Qt5 connect syntax.

nakihito added a commit: rSTAGING384fb8c0c4f9: Update qt/modaloverlay.cpp with Qt5 connect syntax.Apr 7 2020, 21:32

Revision Contents
Changeset List

Path

Size

src/

qt/

modaloverlay.cpp

3 lines

Diff 13771

View Options

Update qt/modaloverlay.cpp with Qt5 connect syntaxClosedPublicActions