Update qt/peertablemodel.cpp with Qt5 connect synax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 00:40.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGcf1c35e8c8a7: Update qt/peertablemodel.cpp with Qt5 connect synax
rABCcf1c35e8c8a7: Update qt/peertablemodel.cpp with Qt5 connect synax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-a9100e8bfc1122159ae47eb2d2f3e6cf

Test Plan

make check
./bitcoin-qt
Help -> Debug -> Peers

pr13529-peertablemodel.png (547×992 px, 43 KB)

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-9

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7912
Build 13834: Bitcoin ABC Buildbot (legacy)
Build 13833: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 30 2019, 00:40

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 00:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 00:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the test plan for this revision. (Show Details)Oct 30 2019, 00:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7912: Diff 13774.Oct 30 2019, 00:57

deadalnix accepted this revision.Oct 30 2019, 15:27

This revision is now accepted and ready to land.Oct 30 2019, 15:27

Closed by commit rABCcf1c35e8c8a7: Update qt/peertablemodel.cpp with Qt5 connect synax (authored by nakihito). · Explain WhyOct 30 2019, 18:18

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABCcf1c35e8c8a7: Update qt/peertablemodel.cpp with Qt5 connect synax.

nakihito added a commit: rSTAGINGcf1c35e8c8a7: Update qt/peertablemodel.cpp with Qt5 connect synax.Apr 7 2020, 21:33

Revision Contents
Changeset List

Path

Size

src/

qt/

peertablemodel.cpp

2 lines

Diff 13774

View Options

Update qt/peertablemodel.cpp with Qt5 connect synaxClosedPublicActions