Update qt/sendcoinsentry.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 22:47.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING42a6a3574905: Update qt/sendcoinsentry.cpp with Qt5 connect syntax
rABC42a6a3574905: Update qt/sendcoinsentry.cpp with Qt5 connect syntax

Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-f6acc8ca9a34f7da6197754154be2a38

Test Plan

make check
./bitcoin-qt
Send

Send coins to yourself.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR13529-10

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 7924
Build 13857: Bitcoin ABC Buildbot (legacy)
Build 13856: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 30 2019, 22:47

Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 22:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 22:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7924: Diff 13807.Oct 30 2019, 22:56

jasonbcox accepted this revision.Oct 30 2019, 23:12

This revision is now accepted and ready to land.Oct 30 2019, 23:12

Closed by commit rABC42a6a3574905: Update qt/sendcoinsentry.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 00:01

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rABC42a6a3574905: Update qt/sendcoinsentry.cpp with Qt5 connect syntax.

nakihito added a commit: rSTAGING42a6a3574905: Update qt/sendcoinsentry.cpp with Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

Path

Size

src/

qt/

sendcoinsentry.cpp

26 lines

Diff 13807

View Options

Update qt/sendcoinsentry.cpp with Qt5 connect syntaxClosedPublicActions