Page MenuHomePhabricator
Differential D4332

Update qt/trafficgraphwidget.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 23:07.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGe9ad31de2709: Update qt/trafficgraphwidget.cpp with Qt5 connect syntax
rABCe9ad31de2709: Update qt/trafficgraphwidget.cpp with Qt5 connect syntax
Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28#diff-0ddd79835da98053f5890ab13e4126d8

Test Plan
make check
./bitcoin-qt
Help -> Debug -> Network Traffic

pr13529-TrafficGraphWidget.png (536×923 px, 30 KB)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13529-11
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7928
Build 13862: Bitcoin ABC Buildbot (legacy)
Build 13861: arc lint + arc unit

Event Timeline

nakihito created this revision.Oct 30 2019, 23:07
Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 23:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 23:07
nakihito planned changes to this revision.Oct 30 2019, 23:07
teamcity added a comment.Oct 30 2019, 23:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito requested review of this revision.Oct 30 2019, 23:08
nakihito edited the test plan for this revision. (Show Details)
jasonbcox accepted this revision.Oct 30 2019, 23:10
This revision is now accepted and ready to land.Oct 30 2019, 23:10
Harbormaster completed remote builds in B7928: Diff 13811.Oct 30 2019, 23:17
teamcity added a comment.Oct 30 2019, 23:17

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABCe9ad31de2709: Update qt/trafficgraphwidget.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 00:06
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCe9ad31de2709: Update qt/trafficgraphwidget.cpp with Qt5 connect syntax.
nakihito added a commit: rSTAGINGe9ad31de2709: Update qt/trafficgraphwidget.cpp with Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

PathSize
src/
qt/
2 lines

Diff 13811

View Options

src/qt/trafficgraphwidget.cpp

Loading...