Page MenuHomePhabricator
Differential D4334

Update qt/transactionview.cpp with Qt5 connect syntax
ClosedPublic
Actions

Authored by nakihito on Oct 30 2019, 23:22.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGb10b542d4863: Update qt/transactionview.cpp with Qt5 connect syntax
rABCb10b542d4863: Update qt/transactionview.cpp with Qt5 connect syntax
Summary

Updates to use Qt5 connect syntax over Qt4.
See https://wiki.qt.io/New_Signal_Slot_Syntax for details.

Partial backport of Core PR13529
https://github.com/bitcoin/bitcoin/pull/13529/commits/f78558f1e39198779bdb17e2b0e256fb99ad4b28?file-filters%5B%5D=.cpp#diff-a2313fe103f15a1a07e0c10c92aceebb

Test Plan
make check
./bitcoin-qt
Send -> Receive -> Transactions

Verify each sub menu opens without issue.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Oct 30 2019, 23:22
Owners added a reviewer: Restricted Owners Package.Oct 30 2019, 23:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 30 2019, 23:22
teamcity added a comment.Oct 30 2019, 23:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Oct 30 2019, 23:31

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B7930: Diff 13814.Oct 30 2019, 23:31
deadalnix accepted this revision.Oct 31 2019, 12:31
This revision is now accepted and ready to land.Oct 31 2019, 12:31
nakihito retitled this revision from Update qt/transactioview.cpp with Qt5 connect syntax to Update qt/transactionview.cpp with Qt5 connect syntax.Oct 31 2019, 17:22
Closed by commit rABCb10b542d4863: Update qt/transactionview.cpp with Qt5 connect syntax (authored by nakihito). · Explain WhyOct 31 2019, 17:29
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCb10b542d4863: Update qt/transactionview.cpp with Qt5 connect syntax.
nakihito added a commit: rSTAGINGb10b542d4863: Update qt/transactionview.cpp with Qt5 connect syntax.Apr 7 2020, 21:33

Revision Contents
Changeset List

PathSize
src/
qt/
98 lines

Diff 13831

View Options

src/qt/transactionview.cpp

Loading...