Page MenuHomePhabricator

[CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled
ClosedPublic

Authored by Fabien on Thu, Oct 31, 17:05.

Details

Summary

D4229 introduced the BUILD_LIBBITCOINCONSENSUS switch, and moved the
include(InstallationHelper) directive conditionally. This will prevent
installing other targets when BUILD_LIBBITCOINCONSENSUS is disabled.
This diff fixes the issue by moving the directive to avoid conditional
inclusion.

Test Plan
cmake -GNinja .. -DBUILD_LIBBITCOINCONSENSUS=OFF
ninja install

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Thu, Oct 31, 17:05
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Oct 31, 17:05
jasonbcox accepted this revision.Thu, Oct 31, 17:13
This revision is now accepted and ready to land.Thu, Oct 31, 17:13