Page MenuHomePhabricator

[CMAKE] Fix missing inclusion when libbitcoinconsensus is disabled
ClosedPublic

Authored by Fabien on Oct 31 2019, 17:05.

Details

Summary

D4229 introduced the BUILD_LIBBITCOINCONSENSUS switch, and moved the
include(InstallationHelper) directive conditionally. This will prevent
installing other targets when BUILD_LIBBITCOINCONSENSUS is disabled.
This diff fixes the issue by moving the directive to avoid conditional
inclusion.

Test Plan
cmake -GNinja .. -DBUILD_LIBBITCOINCONSENSUS=OFF
ninja install

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_fix_include
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7937
Build 13877: Bitcoin ABC Buildbot (legacy)
Build 13876: arc lint + arc unit