Always use SIGHASH_FORKID in the wallet
ClosedPublic
Actions

Authored by deadalnix on Aug 6 2017, 19:32.

Details

Reviewers

freetrader
CCulianu
hanchon

Group Reviewers

Restricted Project

Commits

rSTAGINGe1105490efed: Always use SIGHASH_FORKID in the wallet
rABCe1105490efed: Always use SIGHASH_FORKID in the wallet

Summary

As per title.

Test Plan

Updated related tests.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

alwaysforkidwallet

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 684
Build 684: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 6 2017, 19:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 6 2017, 19:32

CCulianu mentioned this in D430: Update several rpc tests to work post fork..Aug 7 2017, 05:55

Looks good

This revision is now accepted and ready to land.Aug 7 2017, 06:06

Closed by commit rABCe1105490efed: Always use SIGHASH_FORKID in the wallet (authored by deadalnix, committed by deadalnix). · Explain WhyAug 7 2017, 10:43

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

qa/

rpc-tests/

6 lines

6 lines

9 lines

6 lines

src/

wallet/

wallet.cpp

9 lines

Diff 1087

View Options

qa/rpc-tests/import-rescan.py

View Options

qa/rpc-tests/listtransactions.py

View Options

qa/rpc-tests/p2p-feefilter.py

View Options

qa/rpc-tests/receivedby.py

View Options

Always use SIGHASH_FORKID in the walletClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 1087

qa/rpc-tests/import-rescan.py

qa/rpc-tests/listtransactions.py

qa/rpc-tests/p2p-feefilter.py

qa/rpc-tests/receivedby.py

src/wallet/wallet.cpp

Always use SIGHASH_FORKID in the wallet
ClosedPublic
Actions

Revision Contents
Changeset List