Page MenuHomePhabricator
Differential D4451

fix txvalidationcache_tests to not rely on NULLDUMMY
ClosedPublic
Actions

Authored by markblundeberg on Nov 15 2019, 14:38.

Details

Reviewers
jasonbcox
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGdc6b944d546f: fix txvalidationcache_tests to not rely on NULLDUMMY
rABCdc6b944d546f: fix txvalidationcache_tests to not rely on NULLDUMMY
Summary

DISCOURAGE_UPGRADABLE_NOPS is a much more reliable flag for testing
standardness in long term

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
ndt
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

markblundeberg created this revision.Nov 15 2019, 14:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 15 2019, 14:38
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 15 2019, 14:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 15 2019, 14:38

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix accepted this revision.Nov 15 2019, 14:43
This revision is now accepted and ready to land.Nov 15 2019, 14:43
jasonbcox accepted this revision.Nov 15 2019, 14:44
teamcity added a comment.Nov 15 2019, 14:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8125: Diff 14146.Nov 15 2019, 14:47
teamcity added a comment.Nov 15 2019, 14:47

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABCdc6b944d546f: fix txvalidationcache_tests to not rely on NULLDUMMY (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyNov 15 2019, 14:48
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rABCdc6b944d546f: fix txvalidationcache_tests to not rely on NULLDUMMY.
jasonbcox mentioned this in D4474: Added support for -gravitonactivationtime to unit tests.Nov 19 2019, 18:07
jasonbcox mentioned this in rABC4adf7c7104e8: Added support for -gravitonactivationtime to unit tests.Nov 25 2019, 21:14
markblundeberg mentioned this in D4671: fix incomplete txvalidationcache_tests.Dec 9 2019, 20:59
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABC6516515d7bbb: fix incomplete txvalidationcache_tests.Dec 10 2019, 20:24
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGdc6b944d546f: fix txvalidationcache_tests to not rely on NULLDUMMY.Apr 7 2020, 21:41
jasonbcox mentioned this in rSTAGING4adf7c7104e8: Added support for -gravitonactivationtime to unit tests.Apr 7 2020, 21:50
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGING6516515d7bbb: fix incomplete txvalidationcache_tests.Apr 7 2020, 22:01

Revision Contents
Changeset List

PathSize
src/
test/
63 lines

Diff 14146

View Options

src/test/txvalidationcache_tests.cpp

Loading...