Page MenuHomePhabricator
Differential D4462

Use local instance of ArgsManager in getarg_tests
ClosedPublic
Actions

Authored by jasonbcox on Nov 18 2019, 19:49.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING1d290e5f49b7: Use local instance of ArgsManager in getarg_tests
rABC1d290e5f49b7: Use local instance of ArgsManager in getarg_tests
Summary

This test clobbers gArgs for any tests run after it.
Let's stop doing that to allow us to pass activation time via the command line to test tests in the future (diff coming soon).

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
getargs
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8148
Build 14329: Default Diff Build & Tests
Build 14328: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 18 2019, 19:49
Herald added a reviewer: deadalnix. · View Herald TranscriptNov 18 2019, 19:49
teamcity added a comment.Nov 18 2019, 19:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox planned changes to this revision.Nov 18 2019, 19:55
jasonbcox updated this revision to Diff 14189.Nov 18 2019, 20:00

Remove unnecessary ClearArgs()

teamcity added a comment.Nov 18 2019, 20:00

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 18 2019, 20:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8148: Diff 14185.Nov 18 2019, 20:01
teamcity added a comment.Nov 18 2019, 20:13

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8149: Diff 14189.Nov 18 2019, 20:13
jasonbcox added a child revision: D4474: Added support for -gravitonactivationtime to unit tests.Nov 19 2019, 18:07
Fabien accepted this revision.Nov 20 2019, 07:54
This revision is now accepted and ready to land.Nov 20 2019, 07:54
Closed by commit rABC1d290e5f49b7: Use local instance of ArgsManager in getarg_tests (authored by jasonbcox). · Explain WhyNov 20 2019, 17:49
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC1d290e5f49b7: Use local instance of ArgsManager in getarg_tests.
jasonbcox added a commit: rSTAGING1d290e5f49b7: Use local instance of ArgsManager in getarg_tests.Apr 7 2020, 21:45
Fabien mentioned this in D8643: test: Pass ArgsManager into getarg_tests.Dec 10 2020, 11:03
Fabien mentioned this in rABCd0e6cf718672: test: Pass ArgsManager into getarg_tests.Dec 10 2020, 18:59

Revision Contents
Changeset List

PathSize
src/
test/
203 lines

Diff 14185

View Options

src/test/getarg_tests.cpp

Loading...