Differential D452
Fix small Mac OSX memory leak (imported from BU sources) Authored by CCulianu on Aug 8 2017, 22:47.
Details
I noticed there was a very small memory leak in the way CoreFoundation objects were being used on Mac OSX. I submitted that patch months ago to the BU team to fix it, and it's been accepted and merged into their repository. I wanted to bring that patch here to our project, just as a small nit, because it bugs me the way Core originally wrote this code. They clearly don't know how to use the CoreFoundation API ;) Here is the reference in the BU repository: Compile on OSX if you dare, open Qt gui app, toggle load on startup on/off
Diff Detail
Event TimelineComment Actions Seems ok. I have no way of testing this, but the changes do match earlier BU commit 045a999785d .
Comment Actions Adding minor comment to test if I have subscriber/review access.
Comment Actions FYI since you guys don't have MacOS -- here is proof that this thing builds on Mac: Screenshot on Mac:  Compile log: Options used to compile and link:
with wallet = yes
with gui / qt = yes
qt version = 5
with qr = yes
with zmq = yes
with test = yes
with bench = yes
with upnp = auto
debug enabled = no
werror = no
target os = darwin
build os = darwin
CC = gcc
CFLAGS = -g -O2
CPPFLAGS = -DHAVE_BUILD_INFO -D__STDC_FORMAT_MACROS -isystem /opt/local/include -I/opt/local/include/db48 -DMAC_OSX
CXX = g++ -std=c++11
CXXFLAGS = -g -O2 -Wall -Wextra -Wformat -Wvla -Wformat-security -Wno-unused-parameter -Wno-self-assign -Wno-unused-local-typedef -Wno-deprecated-register
LDFLAGS = -Wl,-headerpad_max_install_names -Wl,-dead_strip
calin@CalinMBP2016 ~/tmp/bitcoin-abc $ make -j 6
Making all in src
CXX libbitcoinconsensus_la-arith_uint256.lo
CXX libbitcoinconsensus_la-hash.lo
CXX libbitcoinconsensus_la-pubkey.lo
CXX libbitcoinconsensus_la-uint256.lo
CXX libbitcoinconsensus_la-utilstrencodings.lo
gcc -I. -g -O2 -Wall -Wextra -Wno-unused-function -c src/gen_context.c -o gen_context.o
CXX bitcoind-bitcoind.o
CXX libbitcoin_server_a-addrman.o
CXX libbitcoin_server_a-addrdb.o
CXX libbitcoin_server_a-bloom.o
gcc gen_context.o -o gen_context
./gen_context
CC src/libsecp256k1_la-secp256k1.lo
CXX libbitcoin_server_a-blockencodings.o
CXX libbitcoin_server_a-chain.o
... LOTS OF COMPILING ...
CXX qt/qt_libbitcoinqt_a-csvmodelwriter.o
CXX qt/qt_libbitcoinqt_a-guiutil.o <--- this is the file I touched.. it compiled ok.
CXX qt/qt_libbitcoinqt_a-intro.o
... LOTS MORE COMPILING ...
CXXLD test/test_bitcoin_fuzzy
CXXLD bitcoind
CXXLD test/test_bitcoin
CXXLD bench/bench_bitcoin
AR qt/libbitcoinqt.a
OBJCXXLD qt/bitcoin-qt
CXXLD qt/test/test_bitcoin-qt
Making all in doc/man
make[1]: Nothing to be done for `all'.
make[1]: Nothing to be done for `all-am'.
calin@CalinMBP2016 ~/tmp/bitcoin-abc $Comment Actions Nice, thanks. Accepted on code review basis, @CCulianu you are responsible if this breaks Mac users :-) Comment Actions Ha ha :) Dude I'm the Mac Master. Trust me.. it doesn't. I know Mac API very well. I have written many native macOS apps. Some are in the macOS app store! Core's use of the Mac API was very bad -- they allocated/reference counted a bunch of objects then never release them. Bad bad bad... | ||||||||||||||||||||||||||||||||||