Page MenuHomePhabricator
Differential D453

Always check for replay protection and strict encoding when validating blocks
AbandonedPublic
Actions

Authored by schancel on Aug 9 2017, 11:21.

Details

Reviewers
freetrader
CCulianu
deadalnix
Group Reviewers
Restricted Project
Summary

These are required by BCC. Having a checkpoint after the fork ensure that we can skip part of the validation for earlier blocks, so we are all good.

Test Plan
make check
../qa/pull-tester/rpc-tests.py -extended

Resync a node from scratch on testnet and on mainnet.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
forkidblock
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 704
Build 704: arc lint + arc unit

Event Timeline

deadalnix created this revision.Aug 9 2017, 11:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 9 2017, 11:21
Harbormaster completed remote builds in B704: Diff 1123.Aug 9 2017, 11:21
deadalnix planned changes to this revision.Aug 9 2017, 14:41

This doesn't work yet :)

zander added a subscriber: zander.Aug 14 2017, 18:33

This approach may end up breaking initial-block validation.

schancel commandeered this revision.Feb 24 2018, 07:54
schancel abandoned this revision.
schancel added a reviewer: deadalnix.

Revision Contents
Changeset List

PathSize
src/
10 lines

Diff 1123

View Options

src/validation.cpp

Loading...