Page MenuHomePhabricator
Differential D4531

Add missing parts from PR12954
ClosedPublic
Actions

Authored by Fabien on Nov 25 2019, 11:21.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING874cba527120: Add missing parts from PR12954
rABC874cba527120: Add missing parts from PR12954
Summary

This PR seems to have been backported by pieces over time, and this diff adds what remains.
Most comes from the commit 8c2d695:
https://github.com/bitcoin/bitcoin/pull/12954/commits/8c2d695c4a45bdd9378c7970b0fcba6e1efc01f9

Completes backport of core PR12954:
https://github.com/bitcoin/bitcoin/pull/12954/files

Test Plan
make check
bitcoin-bench
ninja check bench-bitcoin check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12954
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8258
Build 14541: Default Diff Build & Tests
Build 14540: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 25 2019, 11:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 11:21
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 25 2019, 11:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 11:36

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8258: Diff 14363.Nov 25 2019, 11:36
Fabien retitled this revision from Leftovers from PR12954 to Add missing parts from PR12954.Nov 25 2019, 13:32
Fabien edited the summary of this revision. (Show Details)
deadalnix accepted this revision.Nov 25 2019, 13:39
This revision is now accepted and ready to land.Nov 25 2019, 13:39
Closed by commit rABC874cba527120: Add missing parts from PR12954 (authored by Fabien). · Explain WhyNov 25 2019, 14:09
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC874cba527120: Add missing parts from PR12954.
nakihito mentioned this in D5044: Add last missing part from PR12954.Jan 22 2020, 21:00
nakihito mentioned this in rABCa5b58641cce4: Add last missing part from PR12954.Jan 23 2020, 00:18
Fabien added a commit: rSTAGING874cba527120: Add missing parts from PR12954.Apr 7 2020, 21:48
nakihito mentioned this in rSTAGINGa5b58641cce4: Add last missing part from PR12954.Apr 7 2020, 22:37

Revision Contents
Changeset List

PathSize
src/
bench/
3 lines
2 lines
23 lines
4 lines
23 lines
test/
3 lines

Diff 14363

View Options

src/bench/bench_bitcoin.cpp

Loading...
View Options

src/httpserver.h

Loading...
View Options

src/init.cpp

Loading...
View Options

src/logging.h

Loading...
View Options

src/logging.cpp

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...