Differential D4538

Drop IsLimited in favor of IsReachable
ClosedPublic
Actions

Authored by deadalnix on Nov 25 2019, 17:40.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGf52021ab5cb3: Drop IsLimited in favor of IsReachable
rABCf52021ab5cb3: Drop IsLimited in favor of IsReachable

Summary

These two methods have had the same meaning, but inverted, since
110b62f06992d0fb989153afff2dc3aea62a674f. Having one name for a single
concept simplifies the code.

This is a backport of Core PR15138

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 25 2019, 17:40

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 17:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B8270: Diff 14382.Nov 25 2019, 18:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Nov 26 2019, 10:25

This revision is now accepted and ready to land.Nov 26 2019, 10:25

Closed by commit rABCf52021ab5cb3: Drop IsLimited in favor of IsReachable (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhyNov 26 2019, 14:42

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf52021ab5cb3: Drop IsLimited in favor of IsReachable.

deadalnix added a commit: rSTAGINGf52021ab5cb3: Drop IsLimited in favor of IsReachable.Apr 7 2020, 21:51

Revision Contents
Changeset List

Path

Size

src/

init.cpp

15 lines

net.h

16 lines

net.cpp

33 lines

rpc/

net.cpp

2 lines

test/

net_tests.cpp

42 lines

torcontrol.cpp

2 lines

Diff 14428

View Options

src/init.cpp

View Options

src/net.h

View Options

src/net.cpp

View Options

src/rpc/net.cpp

View Options

src/test/net_tests.cpp

View Options

Drop IsLimited in favor of IsReachableClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14428

src/init.cpp

src/net.h

src/net.cpp

src/rpc/net.cpp

src/test/net_tests.cpp

src/torcontrol.cpp

Drop IsLimited in favor of IsReachable
ClosedPublic
Actions

Revision Contents
Changeset List