Page MenuHomePhabricator
Differential D4540

Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
ClosedPublic
Actions

Authored by nakihito on Nov 25 2019, 19:56.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING558347b3d9f6: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
rABC558347b3d9f6: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds
Summary

faa18ca046e9043b2cf68cb1bd17cc8c60fe26d9 wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (MarcoFalke)

Pull request description:

This prevents segfaults, when reading from the freed memory.

Tree-SHA512: 04f8190dea7901cf1cc298d5db98c83b02858f27114c5ef4da738accd176d6647d6b81f3dc39f3d5912b1a981cf0599370fd391c4154ffbde97afc1fac389123

Backport of Core PR13437
https://github.com/bitcoin/bitcoin/pull/13437/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Nov 25 2019, 19:56
Owners added a reviewer: Restricted Owners Package.Nov 25 2019, 19:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 25 2019, 19:56
nakihito added a child revision: D4541: Merge #13138: [tests] Remove accounts from wallet_importprunedfunds.py.Nov 25 2019, 19:57
teamcity added a comment.Nov 25 2019, 20:32

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 25 2019, 20:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8277: Diff 14402.Nov 25 2019, 20:44
Fabien accepted this revision.Nov 26 2019, 10:42
This revision is now accepted and ready to land.Nov 26 2019, 10:42
Closed by commit rABC558347b3d9f6: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyNov 26 2019, 19:04
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC558347b3d9f6: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds.
nakihito added a commit: rSTAGING558347b3d9f6: Merge #13437: wallet: Erase wtxOrderd wtx pointer on removeprunedfunds.Apr 7 2020, 21:52

Revision Contents
Changeset List

PathSize
src/
wallet/
3 lines
15 lines

Diff 14435

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...