Page MenuHomePhabricator

crypto: Remove unused AES-128 code
AbandonedPublic

Authored by fpelliccioni on Tue, Nov 26, 13:48.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Summary

Remove unused AES-128 code.

Backport of Bitcoin Core PR15663
https://github.com/bitcoin/bitcoin/pull/15663

Test Plan
ninja check
ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-edc68d40e
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8294
Build 14610: Bitcoin ABC Buildbot
Build 14609: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Tue, Nov 26, 13:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Nov 26, 13:48
fpelliccioni edited the test plan for this revision. (Show Details)Tue, Nov 26, 13:49
fpelliccioni planned changes to this revision.Tue, Nov 26, 19:16

I have to update the test plan.

fpelliccioni requested review of this revision.Tue, Nov 26, 19:57
fpelliccioni edited the test plan for this revision. (Show Details)

I think we may want to keep this around for QUIC.

Fabien requested changes to this revision.Thu, Nov 28, 07:03

Clearing my queue

This revision now requires changes to proceed.Thu, Nov 28, 07:03

I think we may want to keep this around for QUIC.

Ok, so it is convenient to abandon it, right?

fpelliccioni abandoned this revision.Mon, Dec 9, 14:23