Page MenuHomePhabricator
Differential D4550

crypto: Remove unused AES-128 code
AbandonedPublic
Actions

Authored by fpelliccioni on Nov 26 2019, 13:48.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Summary

Remove unused AES-128 code.

Backport of Bitcoin Core PR15663
https://github.com/bitcoin/bitcoin/pull/15663

Test Plan
ninja check
ninja bench-bitcoin

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-edc68d40e
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8294
Build 14610: Default Diff Build & Tests
Build 14609: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Nov 26 2019, 13:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2019, 13:48
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 26 2019, 13:48

Build Bitcoin-ABC / Diffs / Diff Testing started.

fpelliccioni edited the test plan for this revision. (Show Details)Nov 26 2019, 13:49
teamcity added a comment.Nov 26 2019, 13:59

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8294: Diff 14427.Nov 26 2019, 14:00
fpelliccioni planned changes to this revision.Nov 26 2019, 19:16

I have to update the test plan.

fpelliccioni requested review of this revision.Nov 26 2019, 19:57
fpelliccioni edited the test plan for this revision. (Show Details)
deadalnix added a comment.Nov 26 2019, 22:36

I think we may want to keep this around for QUIC.

Fabien requested changes to this revision.Nov 28 2019, 07:03

Clearing my queue

This revision now requires changes to proceed.Nov 28 2019, 07:03
fpelliccioni added a comment.Dec 5 2019, 19:31
In D4550#110003, @deadalnix wrote:

I think we may want to keep this around for QUIC.

Ok, so it is convenient to abandon it, right?

fpelliccioni abandoned this revision.Dec 9 2019, 14:23

Revision Contents
Changeset List

PathSize
src/
bench/
80 lines
crypto/
49 lines
58 lines
test/
118 lines

Diff 14427

View Options

src/bench/crypto_aes.cpp

Loading...
View Options

src/crypto/aes.h

Loading...
View Options

src/crypto/aes.cpp

Loading...
View Options

src/test/crypto_tests.cpp

Loading...