Page MenuHomePhabricator
Differential D4551

Fix wrong version in clang-format error message and update the doc
ClosedPublic
Actions

Authored by Fabien on Nov 26 2019, 18:57.

Details

Reviewers
deadalnix
Mengerian
Group Reviewers
Restricted Project
Commits
rSTAGING50f28021e062: Fix wrong version in clang-format error message and update the doc
rABC50f28021e062: Fix wrong version in clang-format error message and update the doc
Summary

This fixes the error message that mistakenly request clang-format
version 7.x while D4539 introduced version >= 8.x.

Also update the doc as suggested in D4539.

Test Plan
arc lint --everything

Read the doc.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_clang_format_8
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8296
Build 14614: Default Diff Build & Tests
Build 14613: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 26 2019, 18:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2019, 18:57
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 26 2019, 18:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 26 2019, 19:07

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8296: Diff 14434.Nov 26 2019, 19:07
Mengerian accepted this revision.Nov 26 2019, 19:11
Mengerian added a subscriber: Mengerian.

Looks good to me!

This revision is now accepted and ready to land.Nov 26 2019, 19:11
Closed by commit rABC50f28021e062: Fix wrong version in clang-format error message and update the doc (authored by Fabien). · Explain WhyNov 26 2019, 20:49
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC50f28021e062: Fix wrong version in clang-format error message and update the doc.
Mengerian mentioned this in D4634: Small fix in CONTRIBUTING.md - clang-format-7 still mentioned, but 8 is required.Dec 5 2019, 19:00
Fabien added a commit: rSTAGING50f28021e062: Fix wrong version in clang-format error message and update the doc.Apr 7 2020, 21:52

Revision Contents
Changeset List

PathSize
6 lines
arcanist/
linter/
2 lines

Diff 14434

View Options

CONTRIBUTING.md

Loading...
View Options

arcanist/linter/ClangFormatLinter.php

Loading...