Page MenuHomePhabricator
Differential D4552

refactor: Add and use HaveTxsDownloaded() where appropriate
ClosedPublic
Actions

Authored by fpelliccioni on Nov 26 2019, 19:14.

Details

Reviewers
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate
rABCba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate
Summary

nChainTx is an implementation detail that shouldn't be exposed without a wrapper that comes with appropriate documentation.

Backport of Bitcoin Core PR14863
https://github.com/bitcoin/bitcoin/pull/14863

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
feature-backport-f544e2355
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8297
Build 14616: Default Diff Build & Tests
Build 14615: arc lint + arc unit

Event Timeline

fpelliccioni created this revision.Nov 26 2019, 19:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 26 2019, 19:14
Herald added a reviewer: deadalnix. · View Herald Transcript
fpelliccioni edited the test plan for this revision. (Show Details)Nov 26 2019, 19:14
teamcity added a comment.Nov 26 2019, 19:29

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 26 2019, 19:44

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8297: Diff 14437.Nov 26 2019, 19:44
deadalnix accepted this revision.Nov 26 2019, 22:35
This revision is now accepted and ready to land.Nov 26 2019, 22:35
fpelliccioni updated this revision to Diff 14573.Dec 2 2019, 17:19

rebase from master

teamcity added a comment.Dec 2 2019, 17:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 2 2019, 17:56

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8374: Diff 14573.Dec 2 2019, 17:56
Closed by commit rABCba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate (authored by MarcoFalke <falke.marco@gmail.com>, committed by fpelliccioni). · Explain WhyDec 2 2019, 18:03
This revision was automatically updated to reflect the committed changes.
fpelliccioni added a commit: rABCba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate.
fpelliccioni added a commit: rSTAGINGba82bd9f9256: refactor: Add and use HaveTxsDownloaded() where appropriate.Apr 7 2020, 21:58

Revision Contents
Changeset List

PathSize
src/
10 lines
5 lines
rpc/
2 lines
36 lines

Diff 14437

View Options

src/chain.h

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/validation.cpp

Loading...