Page MenuHomePhabricator
Differential D4561

[tests] style fixes in feature_pruning.py
ClosedPublic
Actions

Authored by Fabien on Nov 27 2019, 10:53.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING7fc0622aca99: [tests] style fixes in feature_pruning.py
rABC7fc0622aca99: [tests] style fixes in feature_pruning.py
Summary

Minor style fixups. No functional change.

Partial backport of core PR15686 (commit 1c29ac4):
https://github.com/bitcoin/bitcoin/pull/15686/commits/1c29ac40fb1853df20572a389db70ce75d80ef93

Depends on D4560.

Test Plan
./test/functional/test_runner.py feature_pruning

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR15686_part1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8307
Build 14633: Default Diff Build & Tests
Build 14632: arc lint + arc unit

Event Timeline

Fabien created this revision.Nov 27 2019, 10:53
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 27 2019, 10:53
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Nov 27 2019, 10:53

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 27 2019, 11:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8307: Diff 14453.Nov 27 2019, 11:09
Fabien added a child revision: D4562: [tests] make pruning test faster.Nov 27 2019, 11:16
Fabien added a child revision: D4563: [tests] fix block time in feature_pruning.py.Nov 27 2019, 13:02
deadalnix accepted this revision.Nov 27 2019, 17:00
deadalnix added inline comments.
test/functional/feature_pruning.py
322

There must be a way to get this better formatted.

This revision is now accepted and ready to land.Nov 27 2019, 17:00
Closed by commit rABC7fc0622aca99: [tests] style fixes in feature_pruning.py (authored by John Newbery <john@johnnewbery.com>, committed by Fabien). · Explain WhyNov 27 2019, 20:09
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC7fc0622aca99: [tests] style fixes in feature_pruning.py.
Fabien added a commit: rSTAGING7fc0622aca99: [tests] style fixes in feature_pruning.py.Apr 7 2020, 21:53

Revision Contents
Changeset List

PathSize
test/
functional/
99 lines

Diff 14453

View Options

test/functional/feature_pruning.py

Loading...