Page MenuHomePhabricator
Differential D4567

Merge #14784: qt: Use WalletModel* instead of the wallet name as map key
ClosedPublic
Actions

Authored by jasonbcox on Nov 27 2019, 20:07.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING24de01d71859: Merge #14784: qt: Use WalletModel* instead of the wallet name as map key
rABC24de01d71859: Merge #14784: qt: Use WalletModel* instead of the wallet name as map key
Summary

91b0c5b09616bb8c5ef8107efb432ce4c7c9a383 qt: Use WalletModel* instead of wallet name in console window (João Barbosa)
b2ce86c3ad79db49ddf06207230512300ec11156 qt: Use WalletModel* instead of wallet name in main window (João Barbosa)
d2a1adffebee86763fafc6f3ed2722f7038654c7 qt: Factor out WalletModel::getDisplayName() (João Barbosa)

Pull request description:

This a small refactor that doesn't change behavior. This is also necessary if in the future we allow renaming wallets.

Tree-SHA512: 1820d0ff28e84b1d862097f1f55b52f94520fa50c9b1939d235a448a48159748c3bbf99b19e4cb1ff4f91efc008c0971b4c25a91f645f9d43792c8aeaa93cf9e

Backport of Core PR14784
https://github.com/bitcoin/bitcoin/pull/14784/files

Completes T698

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14784
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8313
Build 14645: Default Diff Build & Tests
Build 14644: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Nov 27 2019, 20:07
Herald added a reviewer: deadalnix. · View Herald TranscriptNov 27 2019, 20:07
teamcity added a comment.Nov 27 2019, 20:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 27 2019, 20:14

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B8313: Diff 14463!Nov 27 2019, 20:14
jasonbcox edited the summary of this revision. (Show Details)Nov 27 2019, 20:18
jasonbcox added a child revision: D4568: Merge #15149: gui: Show current wallet name in window title.Nov 27 2019, 20:23
Fabien accepted this revision.Nov 27 2019, 20:28
This revision is now accepted and ready to land.Nov 27 2019, 20:28
teamcity added a comment.Nov 27 2019, 21:20

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Nov 27 2019, 21:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8313: Diff 14463.Nov 27 2019, 21:35
Closed by commit rABC24de01d71859: Merge #14784: qt: Use WalletModel* instead of the wallet name as map key (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by jasonbcox). · Explain WhyNov 27 2019, 21:43
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC24de01d71859: Merge #14784: qt: Use WalletModel* instead of the wallet name as map key.
jasonbcox added a commit: rSTAGING24de01d71859: Merge #14784: qt: Use WalletModel* instead of the wallet name as map key.Apr 7 2020, 21:53

Revision Contents
Changeset List

PathSize
src/
qt/
4 lines
4 lines
30 lines
12 lines
52 lines
8 lines
31 lines
3 lines
7 lines

Diff 14463

View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/rpcconsole.h

Loading...
View Options

src/qt/rpcconsole.cpp

Loading...
View Options

src/qt/walletframe.h

Loading...
View Options

src/qt/walletframe.cpp

Loading...
View Options

src/qt/walletmodel.h

Loading...
View Options

src/qt/walletmodel.cpp

Loading...