Page MenuHomePhabricator
Differential D458

Replace use of boost/assign/list_of with more readable C++-11 initializer lists in rpc/rawtransaction.cpp
AbandonedPublic
Actions

Authored by CCulianu on Aug 10 2017, 12:13.

Details

Reviewers
freetrader
deadalnix
Group Reviewers
Restricted Project
Summary

Since bitcoin sources now use C++11, there is no need to use the less-readable boost::assign::list_of. C++11 initializer lists are more readable and maintainable

Test Plan

make check and rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
signrawtx_list_init
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 718
Build 718: arc lint + arc unit

Event Timeline

CCulianu created this revision.Aug 10 2017, 12:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 10 2017, 12:13
freetrader added inline comments.Aug 10 2017, 12:31
src/rpc/rawtransaction.cpp
988 ↗(On Diff #1140)

You sure you didn't drop something? (plain old "ALL")

deadalnix requested changes to this revision.Aug 10 2017, 13:14

What @freetrader said.

This revision now requires changes to proceed.Aug 10 2017, 13:14
CCulianu planned changes to this revision.Aug 10 2017, 13:29

I'll update

src/rpc/rawtransaction.cpp
988 ↗(On Diff #1140)

JESUS christ. SORRY! My bad!

That would have been a horrible oversight.

THANK YOU FOR CATCHING THIS!!

CCulianu updated this revision to Diff 1144.Aug 10 2017, 13:33
CCulianu edited edge metadata.

Forgot one, thanks freetrader

CCulianu added a comment.Aug 10 2017, 13:33

WTF.. arc messed this up. Why?!

CCulianu updated this revision to Diff 1145.Aug 10 2017, 13:38
freetrader accepted this revision.Aug 10 2017, 14:10

I don't know how you managed to paste a raw linted diff in (apparently), but the changeset works alright (built, tested) and the problem is fixed, so I'm happy to accept this one.

Thanks for highlighting good use of braced initializers.

CCulianu abandoned this revision.Aug 10 2017, 14:15

Revision Contents
Changeset List

PathSize
src/
rpc/
1 line

Diff 1144

View Options

src/rpc/rawtransaction.cpp

Loading...