Page MenuHomePhabricator

Replace use of boost/assign/list_of with more readable C++-11 initializer lists in rpc/rawtransaction.cpp
AbandonedPublic

Authored by CCulianu on Aug 10 2017, 12:13.

Details

Reviewers
freetrader
deadalnix
Group Reviewers
Restricted Project
Summary

Since bitcoin sources now use C++11, there is no need to use the less-readable boost::assign::list_of. C++11 initializer lists are more readable and maintainable

Test Plan

make check and rpc-tests.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
signrawtx_list_init
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 718
Build 718: arc lint + arc unit

Event Timeline

src/rpc/rawtransaction.cpp
988 โ†—(On Diff #1140)

You sure you didn't drop something? (plain old "ALL")

This revision now requires changes to proceed.Aug 10 2017, 13:14

I'll update

src/rpc/rawtransaction.cpp
988 โ†—(On Diff #1140)

JESUS christ. SORRY! My bad!

That would have been a horrible oversight.

THANK YOU FOR CATCHING THIS!!

CCulianu edited edge metadata.

Forgot one, thanks freetrader

WTF.. arc messed this up. Why?!

I don't know how you managed to paste a raw linted diff in (apparently), but the changeset works alright (built, tested) and the problem is fixed, so I'm happy to accept this one.

Thanks for highlighting good use of braced initializers.