Page MenuHomePhabricator
Differential D4592

tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree
ClosedPublic
Actions

Authored by deadalnix on Nov 29 2019, 23:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGa1183628d36c: tests: Add missing cs_main locks required when accessing pcoinsdbview…
rABCa1183628d36c: tests: Add missing cs_main locks required when accessing pcoinsdbview…
Summary

This is a backport of Core PR15413

Depends on D4591

Test Plan
make check
ninja bench-bitcoin

Ensure clang doesn't warnign about thread safety.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15413
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8345
Build 14709: Default Diff Build & Tests
Build 14708: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 29 2019, 23:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2019, 23:57
teamcity added a comment.Nov 29 2019, 23:57

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix added a child revision: D4581: Rationalize lock anotation in validation code.Nov 29 2019, 23:57
teamcity added a comment.Nov 30 2019, 00:08

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8345: Diff 14521.Nov 30 2019, 00:08
Fabien added a subscriber: Fabien.Nov 30 2019, 09:53

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

deadalnix added a comment.Nov 30 2019, 13:21
In D4592#110791, @Fabien wrote:

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

It was removed because it was segwit specific. It should be redone at some point in the future, but that won't be a backport.

Fabien accepted this revision.Nov 30 2019, 14:09
This revision is now accepted and ready to land.Nov 30 2019, 14:09
Closed by commit rABCa1183628d36c: tests: Add missing cs_main locks required when accessing pcoinsdbview… (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by deadalnix). · Explain WhyNov 30 2019, 17:37
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCa1183628d36c: tests: Add missing cs_main locks required when accessing pcoinsdbview….
deadalnix added a commit: rSTAGINGa1183628d36c: tests: Add missing cs_main locks required when accessing pcoinsdbview….Apr 7 2020, 21:55

Revision Contents
Changeset List

PathSize
src/
bench/
4 lines
test/
7 lines

Diff 14521

View Options

src/bench/duplicate_inputs.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...