Page MenuHomePhabricator

tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree
ClosedPublic

Authored by deadalnix on Nov 29 2019, 23:57.

Details

Summary

This is a backport of Core PR15413

Depends on D4591

Test Plan
make check
ninja bench-bitcoin

Ensure clang doesn't warnign about thread safety.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15413
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8345
Build 14709: Default Diff Build & Tests
Build 14708: arc lint + arc unit

Event Timeline

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

It was removed because it was segwit specific. It should be redone at some point in the future, but that won't be a backport.

This revision is now accepted and ready to land.Nov 30 2019, 14:09