Page MenuHomePhabricator

tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree
ClosedPublic

Authored by deadalnix on Fri, Nov 29, 23:57.

Details

Summary

This is a backport of Core PR15413

Depends on D4591

Test Plan
make check
ninja bench-bitcoin

Ensure clang doesn't warnign about thread safety.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Nov 29, 23:57
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 29, 23:57
Fabien added a subscriber: Fabien.Sat, Nov 30, 09:53

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

The bench/block_assemble.cpp changes are missing, the bench has not been ported yet. This adds a few more PR as dependencies.
What's the plan with this one ?

It was removed because it was segwit specific. It should be redone at some point in the future, but that won't be a backport.

Fabien accepted this revision.Sat, Nov 30, 14:09
This revision is now accepted and ready to land.Sat, Nov 30, 14:09