Paths

Table of Contentst

Differential D4581

Rationalize lock anotation in validation code
ClosedPublic
Actions

Authored by deadalnix on Nov 29 2019, 15:11.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGc1ff716fb035: Rationalize lock anotation in validation code
rABCc1ff716fb035: Rationalize lock anotation in validation code

Summary

Make sure the annotation are set on declarations rather than implementations, and make sure there are lock assertions consistent with lock annotations.

Depends on D4592

Test Plan

Build with clang and ensure there are no warnings.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Nov 29 2019, 15:11

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 29 2019, 15:11

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8333: Diff 14504.Nov 29 2019, 15:24

This reveals 3 warnings in txvalidationcache_tests.cpp

This revision now requires changes to proceed.Nov 29 2019, 20:24

deadalnix edited the summary of this revision. (Show Details)Nov 29 2019, 23:57

deadalnix added a parent revision: D4592: tests: Add missing cs_main locks required when accessing pcoinsdbview, pcoinsTip or pblocktree.

Rebase on top of D4592

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8346: Diff 14522.Nov 30 2019, 00:12

Fabien accepted this revision.Nov 30 2019, 10:01

This revision is now accepted and ready to land.Nov 30 2019, 10:01

Closed by commit rABCc1ff716fb035: Rationalize lock anotation in validation code (authored by deadalnix). · Explain WhyNov 30 2019, 17:44

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCc1ff716fb035: Rationalize lock anotation in validation code.

deadalnix added a commit: rSTAGINGc1ff716fb035: Rationalize lock anotation in validation code.Apr 7 2020, 21:56

PiRK mentioned this in D12915: Add missing thread safety lock assertions in validation.{h|cpp}.Dec 19 2022, 11:11

PiRK mentioned this in rABC7c8d98584d33: Add missing thread safety lock assertions in validation.{h|cpp}.Dec 19 2022, 13:57

PiRK mentioned this in D14895: doc: Update developer notes.Dec 1 2023, 13:21

PiRK mentioned this in rABC2ea29735f16a: doc: Update developer notes.Dec 4 2023, 06:56

Revision Contents
Changeset List

Path

Size

src/

validation.h

6 lines

validation.cpp

35 lines

Diff 14534

View Options

src/validation.h