Page MenuHomePhabricator

Rationalize lock anotation in validation code
ClosedPublic

Authored by deadalnix on Fri, Nov 29, 15:11.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCc1ff716fb035: Rationalize lock anotation in validation code
Summary

Make sure the annotation are set on declarations rather than implementations, and make sure there are lock assertions consistent with lock annotations.

Depends on D4592

Test Plan

Build with clang and ensure there are no warnings.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Fri, Nov 29, 15:11
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Nov 29, 15:11
Fabien requested changes to this revision.Fri, Nov 29, 20:24
Fabien added a subscriber: Fabien.

This reveals 3 warnings in txvalidationcache_tests.cpp

This revision now requires changes to proceed.Fri, Nov 29, 20:24
deadalnix updated this revision to Diff 14522.Fri, Nov 29, 23:58

Rebase on top of D4592

Fabien accepted this revision.Sat, Nov 30, 10:01
This revision is now accepted and ready to land.Sat, Nov 30, 10:01
This revision was automatically updated to reflect the committed changes.