Differential D4599

Update mempool's mapDelta to use TxId
ClosedPublic
Actions

Authored by deadalnix on Nov 30 2019, 21:22.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING04a26c5bcd54: Update mempool's mapDelta to use TxId
rABC04a26c5bcd54: Update mempool's mapDelta to use TxId

Summary

Using TxId instead of uint256 makes the API more precise.

Depends on D4598

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

mapDeltastxid

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8355
Build 14729: Default Diff Build & Tests
Build 14728: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 30 2019, 21:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 30 2019, 21:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8355: Diff 14538.Nov 30 2019, 21:37

deadalnix added a child revision: D4600: Update mempool and compact block logic to use TxHash.Nov 30 2019, 21:49

deadalnix added a child revision: D4601: tx pool: Use class methods to hide raw map iterator impl details.Nov 30 2019, 22:30

Fabien accepted this revision.Dec 2 2019, 07:53

This revision is now accepted and ready to land.Dec 2 2019, 07:53

Closed by commit rABC04a26c5bcd54: Update mempool's mapDelta to use TxId (authored by deadalnix). · Explain WhyDec 2 2019, 14:33

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC04a26c5bcd54: Update mempool's mapDelta to use TxId.

deadalnix added a commit: rSTAGING04a26c5bcd54: Update mempool's mapDelta to use TxId.Apr 7 2020, 21:57

Revision Contents
Changeset List

Path

Size

src/

txmempool.h

10 lines

txmempool.cpp

17 lines

Diff 14538

View Options

src/txmempool.h