Drop unused GetType() from CSizeComputer
ClosedPublic
Actions

Authored by deadalnix on Dec 1 2019, 00:36.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGe1ba1a45f750: Drop unused GetType() from CSizeComputer
rABCe1ba1a45f750: Drop unused GetType() from CSizeComputer

Summary

This is a partial backport of Core PR13558: https://github.com/bitcoin/bitcoin/pull/13558/commits/da74db0940720407fafaf3582bbaf9c81a4d3b4d

Test Plan

make check
./test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr13558

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8359
Build 14737: Default Diff Build & Tests
Build 14736: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 1 2019, 00:36

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 1 2019, 00:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Dec 1 2019, 00:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8359: Diff 14542.Dec 1 2019, 00:54

deadalnix added a child revision: D4606: Drop minor GetSerializeSize template.Dec 1 2019, 01:44

Fabien accepted this revision.Dec 2 2019, 08:22

This revision is now accepted and ready to land.Dec 2 2019, 08:22

Fabien mentioned this in D4605: Avoid creating a temporary vector for size-prefixed elements.Dec 2 2019, 08:41

Closed by commit rABCe1ba1a45f750: Drop unused GetType() from CSizeComputer (authored by Ben Woosley <ben.woosley@gmail.com>, committed by deadalnix). · Explain WhyDec 2 2019, 13:42

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCe1ba1a45f750: Drop unused GetType() from CSizeComputer.

deadalnix added a commit: rSTAGINGe1ba1a45f750: Drop unused GetType() from CSizeComputer.Apr 7 2020, 21:56

Revision Contents
Changeset List

Path

Size

src/

blockencodings.cpp

2 lines

coins.cpp

2 lines

consensus/

tx_verify.cpp

5 lines

core_write.cpp

3 lines

index/

txindex.cpp

2 lines

miner.cpp

18 lines

policy/

policy.cpp

12 lines

primitives/

transaction.cpp

2 lines

rpc/

blockchain.cpp

12 lines

script/

bitcoinconsensus.cpp

2 lines

seeder/

bitcoin.cpp

4 lines

serialize.h

12 lines

test/

2 lines

2 lines

53 lines

8 lines

7 lines

2 lines

2 lines

13 lines

wallet/

wallet.cpp

4 lines

Diff 14542

View Options

src/blockencodings.cpp

View Options

src/coins.cpp

View Options

src/consensus/tx_verify.cpp

View Options

src/core_write.cpp

View Options

src/index/txindex.cpp

View Options

src/miner.cpp

View Options

src/policy/policy.cpp

View Options

src/primitives/transaction.cpp

View Options

src/rpc/blockchain.cpp

View Options

src/script/bitcoinconsensus.cpp

View Options

src/seeder/bitcoin.cpp

View Options

src/serialize.h

View Options

src/test/blockcheck_tests.cpp

View Options

src/test/flatfile_tests.cpp

View Options

src/test/serialize_tests.cpp

View Options

src/test/uint256_tests.cpp

View Options

src/test/validation_tests.cpp

View Options

src/undo.h

View Options

src/validation.h

View Options

src/validation.cpp

View Options

Drop unused GetType() from CSizeComputerClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 14542

src/blockencodings.cpp

src/coins.cpp

src/consensus/tx_verify.cpp

src/core_write.cpp

src/index/txindex.cpp

src/miner.cpp

src/policy/policy.cpp

src/primitives/transaction.cpp

src/rpc/blockchain.cpp

src/script/bitcoinconsensus.cpp

src/seeder/bitcoin.cpp

src/serialize.h

src/test/blockcheck_tests.cpp

src/test/flatfile_tests.cpp

src/test/serialize_tests.cpp

src/test/uint256_tests.cpp

src/test/validation_tests.cpp

src/undo.h

src/validation.h

src/validation.cpp

src/wallet/wallet.cpp

Drop unused GetType() from CSizeComputer
ClosedPublic
Actions

Revision Contents
Changeset List