Page MenuHomePhabricator
Differential D460

unsigned char => uint8_t
ClosedPublic
Actions

Authored by deadalnix on Aug 10 2017, 12:59.

Details

Reviewers
freetrader
CCulianu
Group Reviewers
Restricted Project
Commits
rSTAGING7698683898ae: unsigned char => uint8_t
rABC7698683898ae: unsigned char => uint8_t
Summary

As per title.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

deadalnix created this revision.Aug 10 2017, 12:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptAug 10 2017, 12:59
Harbormaster completed remote builds in B716: Diff 1142.Aug 10 2017, 12:59
CCulianu edited edge metadata.Aug 10 2017, 14:08

I can't apply the patch.. fails against master.. what did you do, deadalnix?

I read over about half of the changes before my eyes got tired. If I can't apply it, I get nervous. I'll read over the other half later.

In the meantime let me know how to apply it.

deadalnix updated this revision to Diff 1152.Aug 10 2017, 14:35

Rebase, fixup

Harbormaster completed remote builds in B721: Diff 1152.Aug 10 2017, 14:35
CCulianu accepted this revision.Aug 10 2017, 15:04

Ok, I went over everything. Looks good to me.

This revision is now accepted and ready to land.Aug 10 2017, 15:04
Closed by commit rABC7698683898ae: unsigned char => uint8_t (authored by deadalnix, committed by deadalnix). · Explain WhyAug 10 2017, 15:12
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
12 lines
8 lines
2 lines
30 lines
43 lines
bench/
22 lines
10 lines
2 lines
12 lines
3 lines
16 lines
33 lines
4 lines
47 lines
6 lines
8 lines
6 lines
consensus/
2 lines
16 lines
3 lines
11 lines
49 lines
crypto/
52 lines
72 lines
20 lines
ctaes/
24 lines
34 lines
44 lines
5 lines
6 lines
8 lines
6 lines
8 lines
6 lines
12 lines
6 lines
12 lines
6 lines
12 lines
6 lines
12 lines
8 lines
12 lines
59 lines
11 lines
11 lines
31 lines
77 lines
5 lines
2 lines
2 lines
4 lines
4 lines
8 lines
12 lines
6 lines
31 lines
policy/
10 lines
2 lines
35 lines
22 lines
qt/
5 lines
2 lines
9 lines
2 lines
2 lines
4 lines
test/
10 lines
3 lines
4 lines
18 lines
5 lines
rpc/
5 lines
2 lines
13 lines
6 lines
4 lines
script/
10 lines
21 lines
19 lines
23 lines
2 lines
48 lines
8 lines
2 lines
4 lines
7 lines
22 lines
2 lines
6 lines
40 lines
27 lines
test/
56 lines
16 lines
4 lines
26 lines
78 lines
2 lines
10 lines
10 lines
10 lines
6 lines
2 lines
28 lines
102 lines
4 lines
130 lines
13 lines
2 lines
2 lines
4 lines
38 lines
20 lines
38 lines
9 lines
6 lines
16 lines
12 lines
20 lines
52 lines
2 lines
wallet/
32 lines
39 lines
3 lines
14 lines
2 lines
test/
86 lines
7 lines
10 lines
2 lines
36 lines
zmq/
2 lines

Diff 1153

View Options

src/addrdb.cpp

Loading...
View Options

src/addrman.h

Loading...
View Options

src/addrman.cpp

Loading...
View Options

src/base58.h

Loading...
View Options

src/base58.cpp

Loading...
View Options

src/bench/base58.cpp

Loading...
View Options

src/bench/ccoins_caching.cpp

Loading...
View Options

src/bench/rollingbloom.cpp

Loading...
View Options

src/bitcoin-tx.cpp

Loading...
View Options

src/blockencodings.cpp

Loading...
View Options

src/bloom.h

Loading...
View Options

src/bloom.cpp

Loading...
View Options

src/chainparams.h

Loading...
View Options

src/chainparams.cpp

Loading...
View Options

src/coins.h

Loading...
View Options

src/compressor.h

Loading...
View Options

src/compressor.cpp

Loading...
View Options

src/consensus/params.h

Loading...
View Options

src/consensus/validation.h

Loading...
View Options

src/core_io.h

Loading...
View Options

src/core_read.cpp

Loading...
View Options

src/core_write.cpp

Loading...
View Options

src/crypto/aes.h

Loading...
View Options

src/crypto/aes.cpp

Loading...
View Options

src/crypto/common.h

Loading...
View Options

src/crypto/ctaes/bench.c

Loading...
View Options

src/crypto/ctaes/ctaes.h

Loading...
View Options

src/crypto/ctaes/ctaes.c

Loading...
View Options

src/crypto/ctaes/test.c

Loading...
View Options

src/crypto/hmac_sha256.h

Loading...
View Options

src/crypto/hmac_sha256.cpp

Loading...
View Options

src/crypto/hmac_sha512.h

Loading...
View Options

src/crypto/hmac_sha512.cpp

Loading...
View Options

src/crypto/ripemd160.h

Loading...
View Options

src/crypto/ripemd160.cpp

Loading...
View Options

src/crypto/sha1.h

Loading...
View Options

src/crypto/sha1.cpp

Loading...
View Options

src/crypto/sha256.h

Loading...
View Options

src/crypto/sha256.cpp

Loading...
View Options

src/crypto/sha512.h

Loading...
View Options

src/crypto/sha512.cpp

Loading...
View Options

src/dbwrapper.h

Loading...
View Options

src/dbwrapper.cpp

Loading...
View Options

src/hash.h

Loading...
View Options

src/hash.cpp

Loading...
View Options

src/httprpc.cpp

Loading...
View Options

src/key.h

Loading...
View Options

src/key.cpp

Loading...
View Options

src/keystore.h

Loading...
View Options

src/keystore.cpp

Loading...
View Options

src/merkleblock.h

Loading...
View Options

src/miner.cpp

Loading...
View Options

src/net.h

Loading...
View Options

src/net.cpp

Loading...
View Options

src/net_processing.cpp

Loading...
View Options

src/netaddress.h

Loading...
View Options

src/netaddress.cpp

Loading...
View Options

src/policy/policy.cpp

Loading...
View Options

src/protocol.h

Loading...
View Options

src/pubkey.h

Loading...
View Options

src/pubkey.cpp

Loading...
View Options

src/qt/coincontroldialog.cpp

Loading...
View Options

src/qt/guiutil.cpp

Loading...
View Options

src/qt/paymentrequestplus.cpp

Loading...
View Options

src/qt/paymentserver.cpp

Loading...
View Options

src/qt/receiverequestdialog.cpp

Loading...
View Options

src/qt/signverifymessagedialog.cpp

Loading...
View Options

src/qt/test/paymentservertests.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...
View Options

src/random.h

Loading...
View Options

src/random.cpp

Loading...
View Options

src/rest.cpp

Loading...
View Options

src/rpc/misc.cpp

Loading...
View Options

src/rpc/protocol.cpp

Loading...
View Options

src/rpc/rawtransaction.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/rpc/server.cpp

Loading...
View Options

src/script/bitcoinconsensus.h

Loading...
View Options

src/script/bitcoinconsensus.cpp

Loading...
View Options

src/script/interpreter.h

Loading...
View Options

src/script/interpreter.cpp

Loading...
View Options

src/script/ismine.cpp

Loading...
View Options

src/script/script.h

Loading...
View Options

src/script/script.cpp

Loading...
View Options

src/script/sigcache.h

Loading...
View Options

src/script/sigcache.cpp

Loading...
View Options

src/script/sign.h

Loading...
View Options

src/script/sign.cpp

Loading...
View Options

src/script/standard.h

Loading...
View Options

src/script/standard.cpp

Loading...
View Options

src/serialize.h

Loading...
View Options

src/streams.h

Loading...
View Options

src/test/arith_uint256_tests.cpp

Loading...
View Options

src/test/base58_tests.cpp

Loading...
View Options

src/test/bip32_tests.cpp

Loading...
View Options

src/test/bloom_tests.cpp

Loading...
View Options

src/test/crypto_tests.cpp

Loading...
View Options

src/test/dbwrapper_tests.cpp

Loading...
View Options

src/test/hash_tests.cpp

Loading...
View Options

src/test/key_tests.cpp

Loading...
View Options

src/test/miner_tests.cpp

Loading...
View Options

src/test/multisig_tests.cpp

Loading...
View Options

src/test/net_tests.cpp

Loading...
View Options

src/test/netbase_tests.cpp

Loading...
View Options

src/test/script_P2SH_tests.cpp

Loading...
View Options

src/test/script_antireplay_tests.cpp

Loading...
View Options

src/test/script_tests.cpp

Loading...
View Options

src/test/scriptnum10.h

Loading...
View Options

src/test/scriptnum_tests.cpp

Loading...
View Options

src/test/sighash_tests.cpp

Loading...
View Options

src/test/sigopcount_tests.cpp

Loading...
View Options

src/test/streams_tests.cpp

Loading...
View Options

src/test/transaction_tests.cpp

Loading...
View Options

src/test/uint256_tests.cpp

Loading...
View Options

src/test/util_tests.cpp

Loading...
View Options

src/tinyformat.h

Loading...
View Options

src/uint256.h

Loading...
View Options

src/uint256.cpp

Loading...
View Options

src/utilstrencodings.h

Loading...
View Options

src/utilstrencodings.cpp

Loading...
View Options

src/validation.cpp

Loading...
View Options

src/wallet/crypter.h

Loading...
View Options

src/wallet/crypter.cpp

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

src/wallet/test/crypto_tests.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...
View Options

src/zmq/zmqpublishnotifier.cpp

Loading...