Page MenuHomePhabricator
Differential D4620

Merge #15101: gui: Add WalletController
ClosedPublic
Actions

Authored by jasonbcox on Dec 3 2019, 00:01.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING25f189b9aac0: Merge #15101: gui: Add WalletController
rABC25f189b9aac0: Merge #15101: gui: Add WalletController
Summary

0dd9bdefa gui: Refactor to use WalletController (João Barbosa)
8fa271f08 gui: Add WalletController (João Barbosa)
cefb399e2 gui: Use AutoConnection for WalletModel::unload signal (João Barbosa)

Pull request description:

This PR is a subset of the work done in the context of #13100. This change consists in extracting from the application class the code that manages the wallet models.

The role of the `WalletController` instance is to coordinate wallet operations and the window.

Tree-SHA512: 6a824054376730eb7d16c643dd2003f5f60778e8ad3af707b82bc12c48438db179ca4446316b28fb17b206f4b9aba8998419aab8c5dd1f7c32467015732b5094

Backport of Core PR15101
https://github.com/bitcoin/bitcoin/pull/15101/files
Completes T697
Depends on D4619

Test Plan
cmake -GNinja ..
ninja check

cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja check

../configure
make check

../configure --disable-wallet
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
arcpatch-D4620
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8553
Build 15098: Default Diff Build & Tests
Build 15097: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 3 2019, 00:01
Herald added a reviewer: deadalnix. · View Herald TranscriptDec 3 2019, 00:01
jasonbcox planned changes to this revision.Dec 3 2019, 00:02
teamcity added a comment.Dec 3 2019, 00:02

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 3 2019, 00:14

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8381: Diff 14584.Dec 3 2019, 00:14
jasonbcox edited the test plan for this revision. (Show Details)Dec 5 2019, 20:06
jasonbcox updated this revision to Diff 14660.Dec 5 2019, 20:08

Rebase

teamcity added a comment.Dec 5 2019, 20:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 5 2019, 20:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 5 2019, 20:10

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Dec 5 2019, 20:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8436: Diff 14660.Dec 5 2019, 20:19
Fabien accepted this revision.Dec 9 2019, 14:28
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/walletcontroller.cpp
12 ↗(On Diff #14660)

Dito

src/qt/walletcontroller.h
15 ↗(On Diff #14660)

Nit: put Qt includes before system includes

This revision is now accepted and ready to land.Dec 9 2019, 14:28
jasonbcox updated this revision to Diff 14845.Dec 13 2019, 18:10

Moved qt includes before system includes

teamcity added a comment.Dec 13 2019, 18:10

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 13 2019, 18:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8553: Diff 14845.Dec 13 2019, 18:23
Closed by commit rABC25f189b9aac0: Merge #15101: gui: Add WalletController (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by jasonbcox). · Explain WhyDec 22 2019, 17:23
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC25f189b9aac0: Merge #15101: gui: Add WalletController.
jasonbcox added a commit: rSTAGING25f189b9aac0: Merge #15101: gui: Add WalletController.Apr 7 2020, 22:13

Revision Contents
Changeset List

Diff 14845

View Options

src/Makefile.qt.include

Loading...
View Options

src/qt/CMakeLists.txt

Loading...
View Options

src/qt/bitcoin.h

Loading...
View Options

src/qt/bitcoin.cpp

Loading...
View Options

src/qt/bitcoingui.h

Loading...
View Options

src/qt/bitcoingui.cpp

Loading...
View Options

src/qt/walletcontroller.h

Loading...
View Options

src/qt/walletcontroller.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...