Page MenuHomePhabricator

Merge #15101: gui: Add WalletController
AcceptedPublic

Authored by jasonbcox on Tue, Dec 3, 00:01.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Summary

0dd9bdefa gui: Refactor to use WalletController (João Barbosa)
8fa271f08 gui: Add WalletController (João Barbosa)
cefb399e2 gui: Use AutoConnection for WalletModel::unload signal (João Barbosa)

Pull request description:

This PR is a subset of the work done in the context of #13100. This change consists in extracting from the application class the code that manages the wallet models.

The role of the `WalletController` instance is to coordinate wallet operations and the window.

Tree-SHA512: 6a824054376730eb7d16c643dd2003f5f60778e8ad3af707b82bc12c48438db179ca4446316b28fb17b206f4b9aba8998419aab8c5dd1f7c32467015732b5094

Backport of Core PR15101
https://github.com/bitcoin/bitcoin/pull/15101/files
Completes T697
Depends on D4619

Test Plan
cmake -GNinja ..
ninja check

cmake -GNinja -DBUILD_BITCOIN_WALLET=OFF ..
ninja check

../configure
make check

../configure --disable-wallet
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr15101
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 8436
Build 14887: Bitcoin ABC Buildbot
Build 14886: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Tue, Dec 3, 00:01
jasonbcox planned changes to this revision.Tue, Dec 3, 00:02
jasonbcox edited the test plan for this revision. (Show Details)Thu, Dec 5, 20:06
Fabien accepted this revision.Mon, Dec 9, 14:28
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/qt/walletcontroller.cpp
12

Dito

src/qt/walletcontroller.h
15

Nit: put Qt includes before system includes

This revision is now accepted and ready to land.Mon, Dec 9, 14:28