Page MenuHomePhabricator

Merge #15101: gui: Add WalletController

Authored by jasonbcox on Dec 3 2019, 00:01.



0dd9bdefa gui: Refactor to use WalletController (João Barbosa)
8fa271f08 gui: Add WalletController (João Barbosa)
cefb399e2 gui: Use AutoConnection for WalletModel::unload signal (João Barbosa)

Pull request description:

This PR is a subset of the work done in the context of #13100. This change consists in extracting from the application class the code that manages the wallet models.

The role of the `WalletController` instance is to coordinate wallet operations and the window.

Tree-SHA512: 6a824054376730eb7d16c643dd2003f5f60778e8ad3af707b82bc12c48438db179ca4446316b28fb17b206f4b9aba8998419aab8c5dd1f7c32467015732b5094

Backport of Core PR15101
Completes T697
Depends on D4619

Test Plan
cmake -GNinja ..
ninja check

ninja check

make check

../configure --disable-wallet
make check

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Dec 3 2019, 00:01
jasonbcox planned changes to this revision.Dec 3 2019, 00:02
jasonbcox edited the test plan for this revision. (Show Details)Dec 5 2019, 20:06
Fabien accepted this revision.Dec 9 2019, 14:28
Fabien added a subscriber: Fabien.
Fabien added inline comments.
12 ↗(On Diff #14660)


15 ↗(On Diff #14660)

Nit: put Qt includes before system includes

This revision is now accepted and ready to land.Dec 9 2019, 14:28
jasonbcox updated this revision to Diff 14845.Dec 13 2019, 18:10

Moved qt includes before system includes

This revision was automatically updated to reflect the committed changes.