Page MenuHomePhabricator
Differential D4643

[cuckoocache] Use getKey and KeyType for contains
ClosedPublic
Actions

Authored by deadalnix on Dec 5 2019, 13:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGbddacbe760f1: [cuckoocache] Use getKey and KeyType for contains
rABCbddacbe760f1: [cuckoocache] Use getKey and KeyType for contains
Summary

This is another step toward making sure Element can be a key/value map rather than simply a key.

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cuckookeycontains
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8427
Build 14869: Default Diff Build & Tests
Build 14868: arc lint + arc unit

Event Timeline

deadalnix created this revision.Dec 5 2019, 13:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2019, 13:13
teamcity added a comment.Dec 5 2019, 13:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 5 2019, 13:36

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8422: Diff 14638.Dec 5 2019, 13:36
deadalnix updated this revision to Diff 14650.Dec 5 2019, 17:45

Remove now unecessary matchKey

teamcity added a comment.Dec 5 2019, 17:45

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 5 2019, 17:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8427: Diff 14650.Dec 5 2019, 17:57
Fabien accepted this revision.Dec 9 2019, 14:39
This revision is now accepted and ready to land.Dec 9 2019, 14:39
Closed by commit rABCbddacbe760f1: [cuckoocache] Use getKey and KeyType for contains (authored by deadalnix). · Explain WhyDec 10 2019, 03:43
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCbddacbe760f1: [cuckoocache] Use getKey and KeyType for contains.
markblundeberg mentioned this in D4621: allow cuckoocache to function as a map.Dec 10 2019, 04:36
markblundeberg mentioned this in D4834: add sigChecks value to script cache.Jan 5 2020, 02:54
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rABCcdb26502f1fd: add sigChecks value to script cache.Feb 1 2020, 08:10
deadalnix added a commit: rSTAGINGbddacbe760f1: [cuckoocache] Use getKey and KeyType for contains.Apr 7 2020, 22:01
Mark Lundeberg <markblundeberg@users.noreply.github.com> mentioned this in rSTAGINGcdb26502f1fd: add sigChecks value to script cache.Apr 7 2020, 22:45
Fabien mentioned this in D8987: tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue.h and cuckoocache.h. Add fuzzing coverage..Jan 20 2021, 16:27
Fabien mentioned this in rABC0e72cc30e46f: tests: Add fuzzing harnesses for classes/functions in policy/fees.h, checkqueue..Jan 20 2021, 20:09

Revision Contents
Changeset List

PathSize
src/
40 lines

Diff 14650

View Options

src/cuckoocache.h

Loading...