Differential D4654

Fix apptest build failure on Xenial
ClosedPublic
Actions

Authored by Fabien on Dec 5 2019, 21:37.

Tags

None

Subscribers

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING3e0aed9fe2ee: Fix apptest build failure on Xenial
rABC3e0aed9fe2ee: Fix apptest build failure on Xenial

Summary

Due to a missing definition with the Xenial Qt version, ordering of the
headers in apptests.cpp end up being significant.
This only occurs when building with autotools, as CMake does adds the
missing definition (on the command line on through a generated header,
depending on the version).

Test Plan

On Ubuntu Xenial:

make

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix_apptest_build_xenial

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8438
Build 14891: Default Diff Build & Tests
Build 14890: arc lint + arc unit

Event Timeline

Fabien created this revision.Dec 5 2019, 21:37

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 5 2019, 21:37

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Diff Testing started.

Note to reviewers: I tested reversing the ordering on core and they exhibit the same issue.

Thanks for pinning this down.

This revision is now accepted and ready to land.Dec 5 2019, 21:40

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8438: Diff 14664.Dec 5 2019, 21:50

Closed by commit rABC3e0aed9fe2ee: Fix apptest build failure on Xenial (authored by Fabien). · Explain WhyDec 5 2019, 21:54

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC3e0aed9fe2ee: Fix apptest build failure on Xenial.

Fabien added a commit: rSTAGING3e0aed9fe2ee: Fix apptest build failure on Xenial.Apr 7 2020, 22:00

Revision Contents
Changeset List

Path

Size

src/

qt/

test/

14 lines

Diff 14664

src/qt/test/apptests.cpp

Loading...