Page MenuHomePhabricator
Differential D4668

[move only] Move BIP70 code together in preparation to backport PR14451 BIP70 changes
ClosedPublic
Actions

Authored by jasonbcox on Dec 9 2019, 17:19.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING4e65d88e3a16: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70…
rABC4e65d88e3a16: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70…
Summary

Partial backport of Core PR14451, commit 38b98507cdda02ff02a524d41bcc3427ca9e4fd9
https://github.com/bitcoin/bitcoin/pull/14451/commits/38b98507cdda02ff02a524d41bcc3427ca9e4fd9

This was done out of order to keep all of the BIP70 related changes in one diff.
It was split out as a result of feedback in D4619.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr14451-move-only
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8455
Build 14921: Default Diff Build & Tests
Build 14920: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 9 2019, 17:19
Herald added a reviewer: deadalnix. · View Herald TranscriptDec 9 2019, 17:19
teamcity added a comment.Dec 9 2019, 17:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)Dec 9 2019, 17:20
teamcity added a comment.Dec 9 2019, 17:36

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8455: Diff 14694.Dec 9 2019, 17:36
jasonbcox edited the summary of this revision. (Show Details)Dec 9 2019, 17:52
Fabien accepted this revision.Dec 9 2019, 18:03
This revision is now accepted and ready to land.Dec 9 2019, 18:03
Closed by commit rABC4e65d88e3a16: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70… (authored by jasonbcox). · Explain WhyDec 9 2019, 18:04
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABC4e65d88e3a16: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70….
jasonbcox added a child revision: D4619: Merge #14451: Allow building GUI without BIP70 support.Dec 9 2019, 18:12
jasonbcox added a commit: rSTAGING4e65d88e3a16: [move only] Move BIP70 code together in preparation to backport PR14451 BIP70….Apr 7 2020, 22:01

Revision Contents
Changeset List

PathSize
src/
qt/
32 lines
297 lines

Diff 14694

View Options

src/qt/paymentserver.h

Loading...
View Options

src/qt/paymentserver.cpp

Loading...