Privatize CWallet::AddToWalletIfInvolvingMe
ClosedPublic
Actions

Authored by nakihito on Dec 10 2019, 02:04.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING8f33f2521eca: Privatize CWallet::AddToWalletIfInvolvingMe
rABC8f33f2521eca: Privatize CWallet::AddToWalletIfInvolvingMe

Summary

And document in the header.

Partial backport of Core PR13651
https://github.com/bitcoin/bitcoin/pull/13651/commits/17e6aa8e333dbf3631fb09dc6eb7ede1937269df

Depends on D4675

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Dec 10 2019, 02:04

Owners added a reviewer: Restricted Owners Package.Dec 10 2019, 02:04

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 10 2019, 02:04

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito edited the summary of this revision. (Show Details)Dec 10 2019, 02:05

nakihito added a parent revision: D4675: Extract CWallet::MarkInputsDirty.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8467: Diff 14714.Dec 10 2019, 02:22

jasonbcox accepted this revision.Dec 10 2019, 20:44

This revision is now accepted and ready to land.Dec 10 2019, 20:44

Closed by commit rABC8f33f2521eca: Privatize CWallet::AddToWalletIfInvolvingMe (authored by Ben Woosley <ben.woosley@gmail.com>, committed by nakihito). · Explain WhyDec 11 2019, 19:22

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC8f33f2521eca: Privatize CWallet::AddToWalletIfInvolvingMe.

nakihito added a commit: rSTAGING8f33f2521eca: Privatize CWallet::AddToWalletIfInvolvingMe.Apr 7 2020, 22:03

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

24 lines

wallet.cpp

13 lines

Diff 14778

View Options

src/wallet/wallet.h