Page MenuHomePhabricator
Differential D4722

refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound
ClosedPublic
Actions

Authored by majcosta on Dec 13 2019, 16:09.

Details

Reviewers
deadalnix
jasonbcox
nakihito
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING826e21daed54: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound
rABC826e21daed54: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound
Summary

This is a backport of Core PR16674 - https://github.com/bitcoin/bitcoin/pull/16674

Test Plan
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
backport-qt-qsort
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8549
Build 15090: Default Diff Build & Tests
Build 15089: arc lint + arc unit

Event Timeline

majcosta created this revision.Dec 13 2019, 16:09
Owners added a reviewer: Restricted Owners Package.Dec 13 2019, 16:09
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 13 2019, 16:09
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Dec 13 2019, 16:09

Build Bitcoin-ABC / Diffs / Diff Testing started.

majcosta planned changes to this revision.Dec 13 2019, 16:15

going to add the other two commits to this revision

teamcity added a comment.Dec 13 2019, 16:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8549: Diff 14839.Dec 13 2019, 16:28
majcosta updated this revision to Diff 14841.Dec 13 2019, 16:35

added commits fea33cbbdfb4673033f3414bf1613591ff654aac and 59373e3e94015316bcaa03a7b9c2e6f442641720

teamcity added a comment.Dec 13 2019, 16:35

Build Bitcoin-ABC / Diffs / Diff Testing started.

majcosta updated this revision to Diff 14842.Dec 13 2019, 16:40

accidentally removed brackets from single line if statement. corrected.

teamcity added a comment.Dec 13 2019, 16:40

Build Bitcoin-ABC / Diffs / Diff Testing started.

majcosta edited the summary of this revision. (Show Details)Dec 13 2019, 16:44
teamcity added a comment.Dec 13 2019, 16:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8550: Diff 14841.Dec 13 2019, 16:46
teamcity added a comment.Dec 13 2019, 16:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8551: Diff 14842.Dec 13 2019, 16:57
jasonbcox requested changes to this revision.Dec 13 2019, 18:02
jasonbcox added a subscriber: jasonbcox.

Please also remove the strikethrough portions of the summary. This is going to end up showing up in git log and I don't see how it will be useful after this is landed.

src/qt/bantablemodel.cpp
62 ↗(On Diff #14842)

add brackets

This revision now requires changes to proceed.Dec 13 2019, 18:02
majcosta edited the summary of this revision. (Show Details)Dec 13 2019, 18:04
majcosta updated this revision to Diff 14844.Dec 13 2019, 18:08

included missing brackets around single line if statement

teamcity added a comment.Dec 13 2019, 18:08

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 13 2019, 18:18

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8552: Diff 14844.Dec 13 2019, 18:18
jasonbcox accepted this revision.Dec 13 2019, 20:12
This revision is now accepted and ready to land.Dec 13 2019, 20:12
nakihito accepted this revision.Dec 13 2019, 21:03
Closed by commit rABC826e21daed54: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound (authored by fanquake <fanquake@gmail.com>, committed by majcosta). · Explain WhyDec 13 2019, 23:54
This revision was automatically updated to reflect the committed changes.
majcosta added a commit: rABC826e21daed54: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.
majcosta added a commit: rSTAGING826e21daed54: refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound.Apr 7 2020, 22:04

Revision Contents
Changeset List

Diff 14839

View Options

src/qt/addresstablemodel.cpp

Loading...
View Options

src/qt/transactiontablemodel.cpp

Loading...