Page MenuHomePhabricator

refactor: replace qLowerBound & qUpperBound with std:: upper_bound & lower_bound
ClosedPublic

Authored by majcosta on Dec 13 2019, 16:09.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
backport-qt-qsort
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8549
Build 15090: Default Diff Build & Tests
Build 15089: arc lint + arc unit

Event Timeline

Owners added a reviewer: Restricted Owners Package.Dec 13 2019, 16:09

going to add the other two commits to this revision

added commits fea33cbbdfb4673033f3414bf1613591ff654aac and 59373e3e94015316bcaa03a7b9c2e6f442641720

accidentally removed brackets from single line if statement. corrected.

jasonbcox requested changes to this revision.Dec 13 2019, 18:02
jasonbcox added a subscriber: jasonbcox.

Please also remove the strikethrough portions of the summary. This is going to end up showing up in git log and I don't see how it will be useful after this is landed.

src/qt/bantablemodel.cpp
62 ↗(On Diff #14842)

add brackets

This revision now requires changes to proceed.Dec 13 2019, 18:02

included missing brackets around single line if statement

This revision is now accepted and ready to land.Dec 13 2019, 20:12