Merge #14474: bitcoin-tx: Use constant for n pubkeys check
ClosedPublic
Actions

Authored by nakihito on Dec 17 2019, 01:03.

Details

Reviewers

deadalnix
Fabien
jasonbcox

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING154c52dc3d70: Merge #14474: bitcoin-tx: Use constant for n pubkeys check
rABC154c52dc3d70: Merge #14474: bitcoin-tx: Use constant for n pubkeys check

Summary

1f01fe0257 bitcoin-tx: Use constant for n pubkeys check (Antoine Le Calvez)

Pull request description:

Use the constant for the maximum number of public keys in a multisig script defined in script/script.h instead of hardcoding it.

Tree-SHA512: 83e6c46df907944d0d993159955e402784415536d61fdb5a5becba2b042e37ad2a291b27301c1b169416cb71c823a571d82257512cd4a64848a27a24c875fcc6

Backport of Core PR14474
https://github.com/bitcoin/bitcoin/pull/14474/

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR14474

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8582
Build 15152: Default Diff Build & Tests
Build 15151: arc lint + arc unit

Event Timeline

nakihito created this revision.Dec 17 2019, 01:03

Owners added a reviewer: Restricted Owners Package.Dec 17 2019, 01:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 17 2019, 01:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8582: Diff 14890.Dec 17 2019, 01:14

Fabien accepted this revision.Dec 17 2019, 11:04

This revision is now accepted and ready to land.Dec 17 2019, 11:04

Closed by commit rABC154c52dc3d70: Merge #14474: bitcoin-tx: Use constant for n pubkeys check (authored by Pieter Wuille <pieter.wuille@gmail.com>, committed by nakihito). · Explain WhyDec 17 2019, 18:58

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC154c52dc3d70: Merge #14474: bitcoin-tx: Use constant for n pubkeys check.

nakihito added a commit: rSTAGING154c52dc3d70: Merge #14474: bitcoin-tx: Use constant for n pubkeys check.Apr 7 2020, 22:06

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

4 lines

Diff 14890

View Options

Merge #14474: bitcoin-tx: Use constant for n pubkeys checkClosedPublicActions