Page MenuHomePhabricator

fix some tests that rely on free transactions being submittable via RPC
ClosedPublic

Authored by markblundeberg on Dec 17 2019, 07:51.

Details

Summary

Testing of the free transaction mechanism revealed that some tests were accidentally
relying on free high priority transactions being submitted via RPC, which
would be forbidden if they were submitted over P2P protocol.

Also, some tests were unnecessarily invoking the relaypriority option (what this
does is count *all* transactions as 'high priority' and therefore they are only
subject to the free limiter). There remains only one test (abc-p2p-compactblocks.py)
relies on -norelaypriority, and this is not due to RPC submission but rather
because the way it works is a bit weird as noted (it makes giant transactions with
0 fee, and expects them to all be put back into mempool when a reorg happens).

Test Plan
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

test/functional/abc-p2p-compactblocks.py
95 ↗(On Diff #14899)

Should the fOverrideMempoolLimit flag take care o this? If not, then that's a problem.

336 ↗(On Diff #14899)

dito

This revision is now accepted and ready to land.Dec 17 2019, 23:42

(rebased for landing D4746 which also touched abc-transaction-ordering)