Page MenuHomePhabricator
Differential D4760

Merge #13419: [tests] Speed up knapsack_solver_test by not recreating wallet 100 times.
ClosedPublic
Actions

Authored by nakihito on Dec 18 2019, 19:52.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING06c02066fff0: Merge #13419: [tests] Speed up knapsack_solver_test by not recreating wallet…
rABC06c02066fff0: Merge #13419: [tests] Speed up knapsack_solver_test by not recreating wallet…
Summary

a679109be40491222c458fdbef58f68509dae0bd Speed up knapsack_solver_test by not recreating wallet 100 times. (lucash.dev@gmail.com)

Pull request description:

Optimization of `knapsack_solver_test`by moving an expensive wallet creation to outside a 100x for loop.

On my (slow) machine:

```
before:        9.8s
after:         6.2s
--------------------
saved:         3.6s (36%)
```

This PR was split from #13050. Also see #10026.

Tree-SHA512: bde1a856b5f076a5845e14d1a924855c8c91742c3139b47903081289b21d01fef6f2d1fd8947058728a57de56f877bab3866af8cd1d25ba2daa44411752cdb2f

Backport of Core PR13419
https://github.com/bitcoin/bitcoin/pull/13419/

Review note: Easier to see changes if you hide white space changes (https://github.com/bitcoin/bitcoin/pull/13419/files?utf8=%E2%9C%93&diff=split&w=1)

Test Plan
make check
time(./test_bitcoin --run_test=coinselector_tests/knapsack_solver_test)

Pre-patch:

real    0m4.841s
user    0m4.764s
sys     0m0.076s

Post-patch:

real    0m2.340s
user    0m2.328s
sys     0m0.008s

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13419
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8631
Build 15248: Default Diff Build & Tests
Build 15247: arc lint + arc unit

Event Timeline

nakihito created this revision.Dec 18 2019, 19:52
Owners added a reviewer: Restricted Owners Package.Dec 18 2019, 19:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 18 2019, 19:52
nakihito planned changes to this revision.Dec 18 2019, 19:52
teamcity added a comment.Dec 18 2019, 19:52

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 18 2019, 20:03

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8631: Diff 14974.Dec 18 2019, 20:03
nakihito requested review of this revision.Dec 18 2019, 20:34
nakihito edited the test plan for this revision. (Show Details)
nakihito edited the summary of this revision. (Show Details)Dec 18 2019, 20:36
Fabien accepted this revision.Dec 19 2019, 07:49
This revision is now accepted and ready to land.Dec 19 2019, 07:49
Closed by commit rABC06c02066fff0: Merge #13419: [tests] Speed up knapsack_solver_test by not recreating wallet… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyDec 19 2019, 18:17
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC06c02066fff0: Merge #13419: [tests] Speed up knapsack_solver_test by not recreating wallet….
nakihito added a commit: rSTAGING06c02066fff0: Merge #13419: [tests] Speed up knapsack_solver_test by not recreating wallet….Apr 7 2020, 22:10

Revision Contents
Changeset List

PathSize
src/
wallet/
test/
59 lines

Diff 14974

View Options

src/wallet/test/coinselector_tests.cpp

Loading...