Page MenuHomePhabricator
Differential D4798

[tests] allow BOOST_CHECK_EQUAL for ScriptErrors
ClosedPublic
Actions

Authored by markblundeberg on Dec 23 2019, 02:19.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGa194dedba3c1: [tests] allow BOOST_CHECK_EQUAL for ScriptErrors
rABCa194dedba3c1: [tests] allow BOOST_CHECK_EQUAL for ScriptErrors
Summary

as per title -- BOOST_*_EQUAL needs operator<< to be defined for
the type so it can print something like "A != B".

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
scripterrortest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 8682
Build 15350: Default Diff Build & Tests
Build 15349: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Dec 23 2019, 02:19
Herald added a reviewer: Restricted Project. · View Herald TranscriptDec 23 2019, 02:19
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg added a child revision: D4678: add nSigChecks counting to EvalScript.Dec 23 2019, 02:21
teamcity added a comment.Dec 23 2019, 02:44

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Dec 23 2019, 03:02

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8682: Diff 15075.Dec 23 2019, 03:02
Fabien accepted this revision.Dec 23 2019, 10:49
This revision is now accepted and ready to land.Dec 23 2019, 10:49
deadalnix accepted this revision.Dec 27 2019, 18:02
Closed by commit rABCa194dedba3c1: [tests] allow BOOST_CHECK_EQUAL for ScriptErrors (authored by Mark Lundeberg <markblundeberg@users.noreply.github.com>). · Explain WhyDec 30 2019, 02:31
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rABCa194dedba3c1: [tests] allow BOOST_CHECK_EQUAL for ScriptErrors.
Mark Lundeberg <markblundeberg@users.noreply.github.com> added a commit: rSTAGINGa194dedba3c1: [tests] allow BOOST_CHECK_EQUAL for ScriptErrors.Apr 7 2020, 22:14

Revision Contents
Changeset List

PathSize
src/
test/
7 lines
6 lines

Diff 15075

View Options

src/test/test_bitcoin.h

Loading...
View Options

src/test/test_bitcoin.cpp

Loading...