Fix missing newline at end of keys file
ClosedPublic
Actions

Authored by jasonbcox on Dec 30 2019, 20:03.

Details

Reviewers

deadalnix
nakihito
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING1e6248f0dde9: Fix missing newline at end of keys file
rABC1e6248f0dde9: Fix missing newline at end of keys file

Summary

check-keys fails to process the last line if it does not
end in a newline.

Test Plan

check-keys.sh

Diff Detail

Repository

rABC Bitcoin ABC

Branch

keys-newline

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 8692
Build 15370: Default Diff Build & Tests
Build 15369: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Dec 30 2019, 20:03

Herald added a reviewer: deadalnix. · View Herald TranscriptDec 30 2019, 20:03

Build Bitcoin-ABC / Diffs / Diff Testing started.

jasonbcox added a child revision: D4806: Fix nits in check-keys.sh.Dec 30 2019, 20:04

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B8692: Diff 15088.Dec 30 2019, 20:20

nakihito accepted this revision.Dec 31 2019, 21:04

This revision is now accepted and ready to land.Dec 31 2019, 21:04

Fabien accepted this revision.Jan 2 2020, 17:27

Closed by commit rABC1e6248f0dde9: Fix missing newline at end of keys file (authored by jasonbcox). · Explain WhyJan 2 2020, 17:28

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC1e6248f0dde9: Fix missing newline at end of keys file.

jasonbcox added a commit: rSTAGING1e6248f0dde9: Fix missing newline at end of keys file.Apr 7 2020, 22:14

Revision Contents
Changeset List

Path

Size

contrib/

gitian-signing/

keys.txt

2 lines

Diff 15088

View Options

contrib/gitian-signing/keys.txt

Fix missing newline at end of keys fileClosedPublicActions