Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cleanup6
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 8700 Build 15386: Default Diff Build & Tests Build 15385: arc lint + arc unit
Event Timeline
| doc/release-notes.md | ||
|---|---|---|
| 9 | Can you make it a bit more explicit ? e.g. by adding something like: It is no longer possible to pass a `priority_delta` value, only `fee_delta` is supported. | |
| doc/release-notes.md | ||
|---|---|---|
| 10 ↗ | (On Diff #15127) | Core release note say: The `prioritisetransaction` RPC no longer takes a `priority_delta` argument, which is replaced by a `dummy` argument for backwards compatibility with clients using positional arguments. The RPC is still used to change the apparent fee-rate of the transaction by using the `fee_delta` argument. I think we should probably keep the dummy around for a while, and add a deprecated flag to handle the transition. |
| doc/release-notes.md | ||
|---|---|---|
| 10 ↗ | (On Diff #15127) | This will break people's code using the node, which we don't want to do without giving them a fair warning and long enough to adapt. |
Yeah fair enough, I was half-expecting this review. Actually the original PR 9602 did fully remove the argument, and I had no idea they restored the parameter as a dummy argument. I just invented the intermediate dummy step myself (the parent Diff) since it was a no-brainer.
The parameter was actually restored in https://github.com/bitcoin/bitcoin/pull/10252/files -- should we replicate its functionality in that "Not supported, so must be zero or null." ?