Page MenuHomePhabricator

finish backporting PR9602 - misc
ClosedPublic

Authored by markblundeberg on Dec 31 2019, 03:43.

Details

Summary

some small things missed when removing free transaction sending / relay

https://github.com/bitcoin/bitcoin/pull/9602/files

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Snippet of first build failure:
lines=16,COUNTEREXAMPLE```[03:54:38] : [Step 1/1] [0m [0;34mp2p_sendheaders.py | ✓ Passed | 11 s
[03:54:38] : [Step 1/1] [0m [0;34mp2p_unrequested_blocks.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_bind.py | ✓ Passed | 4 s
[03:54:38]W: [Step 1/1] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[03:54:38] : [Step 1/1] [0m [0;34mrpc_blockchain.py | ✓ Passed | 6 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_createmultisig.py | ✓ Passed | 3 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_decodescript.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_deprecated.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_estimatefee.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_fundrawtransaction.py | ✓ Passed | 23 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_getblockstats.py | ✓ Passed | 1 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_getchaintips.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_help.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_invalidateblock.py | ✓ Passed | 5 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_named_arguments.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_net.py | ✓ Passed | 1 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_preciousblock.py | ✓ Passed | 1 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_psbt.py | ✓ Passed | 7 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_rawtransaction.py | ✓ Passed | 22 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_scantxoutset.py | ✓ Passed | 3 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_signmessage.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_signrawtransaction.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_txoutproof.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_uptime.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_users.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mrpc_zmq.py | ✓ Passed | 1 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_abandonconflict.py | ✓ Passed | 5 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_basic.py | ✓ Passed | 24 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_disable.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_disableprivatekeys.py | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_disableprivatekeys.py --usecli | ✓ Passed | 0 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_dump.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_encryption.py | ✓ Passed | 5 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_groups.py | ✓ Passed | 9 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_hd.py | ✓ Passed | 4 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_import_rescan.py | ✓ Passed | 3 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_importmulti.py | ✓ Passed | 1 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_importprunedfunds.py | ✓ Passed | 1 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_keypool.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_keypool_topup.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_labels.py | ✓ Passed | 3 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_listreceivedby.py | ✓ Passed | 13 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_listsinceblock.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_listtransactions.py | ✓ Passed | 7 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_multiwallet.py | ✓ Passed | 7 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_multiwallet.py --usecli | ✓ Passed | 8 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_resendwallettransactions.py | ✓ Passed | 1 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_txn_clone.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_txn_clone.py --mineblock | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_txn_doublespend.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_txn_doublespend.py --mineblock | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;34mwallet_zapwallettxes.py | ✓ Passed | 2 s
[03:54:38] : [Step 1/1] [0m [0;31mp2p_compactblocks.py | ✖ Failed | 6 s
[03:54:38] : [Step 1/1] [0m [0;31m [1m
[03:54:38] : [Step 1/1] ALL | ✖ Failed | 385 s (accumulated)
[03:54:38] : [Step 1/1] [0m [0mRuntime: 221 s
[03:54:38] : [Step 1/1]
[03:54:38] : [Step 1/1] * Output of /tmp/sanitizer_logs/*.log.* *
[03:54:38]W: [Step 1/1] Process exited with code 1
[03:54:38]E: [Step 1/1] Process exited with code 1 (Step: Command Line)

Each failure log is accessible here:
[[https://build.bitcoinabc.org/viewLog.html?tab=buildLog&logTab=tree&filter=debug&expand=all&buildId=24817&guest=1&_focus=1855 | bitcoin_abc_tests: p2p_compactblocks.py]]
This revision is now accepted and ready to land.Jan 2 2020, 13:16